Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing SendSmsOptions returning error #17328

Closed
lav13enrose opened this issue Mar 14, 2021 · 4 comments
Closed

Importing SendSmsOptions returning error #17328

lav13enrose opened this issue Mar 14, 2021 · 4 comments
Assignees
Labels
Communication customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@lav13enrose
Copy link

  • Package Name: azure-communication-sms
  • Package Version: 1.0.0b6
  • Operating System: Ubuntu on Windows Linux Subsystem
  • Python Version: 2.7

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Importing SendSmsOptions
  2. Returning "ImportError: cannot import name SendSmsOptions"

Expected behavior
When using azure-communication-sms==1.0.0b4 everything running fine

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Explain please

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 14, 2021
@catalinaperalta
Copy link
Member

Thanks for reaching out @lav13enrose! We'll investigate ASAP.
Adding @turalf who can comment more on this issue.

@catalinaperalta catalinaperalta added bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention Workflow: This issue is responsible by Azure service team. Communication and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 15, 2021
@ghost
Copy link

ghost commented Mar 15, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @acsdevx-msft.

Issue Details
  • Package Name: azure-communication-sms
  • Package Version: 1.0.0b6
  • Operating System: Ubuntu on Windows Linux Subsystem
  • Python Version: 2.7

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Importing SendSmsOptions
  2. Returning "ImportError: cannot import name SendSmsOptions"

Expected behavior
When using azure-communication-sms==1.0.0b4 everything running fine

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Explain please

Author: lav13enrose
Assignees: turalf
Labels:

Communication, Service Attention, bug, customer-reported, question

Milestone: -

@catalinaperalta catalinaperalta removed the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 15, 2021
@annatisch
Copy link
Member

annatisch commented Mar 15, 2021

Thanks @lav13enrose!
cc @lsundaralingam

I don't believe SmsSendOptions is still a type in the Python SDK. Can you please describe what you're using it for so we can get you the latest code to achieve it?
If you could also give us a link to any samples you saw that use this object so we can update them, that would be awesome :)

This is the full method signature for sending a message - it's likely the options you need have been moved to keyword-only arguments - if not, please let us know!

def send(
    self,
    from: str,
    to_: Union[str, List[str]],
    message: str,
    *,
    enable_delivery_report: bool,
    tag: str
) -> List[SmsSendResult]

@lsundaralingam
Copy link
Member

Hi @lav13enrose,

As Anna mentioned, SendSmsOptions is not a type anymore, so there's no need to import it. You can use kwargs instead to pass in optional parameters like enable_delivery_report and tag. For examples, please see the samples here.

I'm closing this issue, but feel free to reopen if anything comes up.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 20, 2022
Update readmes for SDK Auto-gen (Azure#17328)

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.md

* Update readme.java.md

* Update readme.go.md

* Update readme.md

* Remove multiapi

* Update readme.md

* Update readme.python.md

Co-authored-by: Yuchao Yan <[email protected]>
msyyc added a commit that referenced this issue Feb 7, 2022
* CodeGen from PR 17328 in Azure/azure-rest-api-specs
Update readmes for SDK Auto-gen (#17328)

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.md

* Update readme.java.md

* Update readme.go.md

* Update readme.md

* Remove multiapi

* Update readme.md

* Update readme.python.md

Co-authored-by: Yuchao Yan <[email protected]>

* version,CHANGELOG

* Update CHANGELOG.md

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Jiefeng Chen <[email protected]>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Apr 10, 2022
…2615)

* CodeGen from PR 17328 in Azure/azure-rest-api-specs
Update readmes for SDK Auto-gen (Azure#17328)

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

* Update readme.md

* Update readme.java.md

* Update readme.go.md

* Update readme.md

* Remove multiapi

* Update readme.md

* Update readme.python.md

Co-authored-by: Yuchao Yan <[email protected]>

* version,CHANGELOG

* Update CHANGELOG.md

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Jiefeng Chen <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Communication customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants