Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Make azure-common file-based auth exceptions more helpful #16791

Closed
mccoyp opened this issue Feb 17, 2021 · 1 comment · Fixed by #17395
Closed

[Identity] Make azure-common file-based auth exceptions more helpful #16791

mccoyp opened this issue Feb 17, 2021 · 1 comment · Fixed by #17395
Assignees
@mccoyp
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] April

Comments

@mccoyp
Copy link
Member

mccoyp commented Feb 17, 2021

Context: users who have relied on azure-common's factory methods like get_client_from_auth_file and get_client_from_json_dict have been unable to use this authentication pattern with clients using azure-identity (see #16760, for example).

Attempting to use these factory methods with track 2 clients yields an unhelpful exception (e.g. TypeError: __init__() missing 1 required positional argument: 'credential'). Instead, exceptions caused by this pattern should:

  1. Point to azure-identity credentials
  2. Point to a sample/guidance for migrating from this scenario, which should be reachable at an aka.ms link
@mccoyp mccoyp added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Feb 17, 2021
@mccoyp mccoyp added this to the [2021] March milestone Feb 17, 2021
@mccoyp mccoyp self-assigned this Feb 17, 2021
@lmazuel lmazuel modified the milestones: [2021] March, [2021] April Mar 13, 2021
@lmazuel
Copy link
Member

lmazuel commented Mar 17, 2021

Link we want to show: https://aka.ms/azsdk/python/azidmigration

@lmazuel lmazuel mentioned this issue Mar 17, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 6, 2022
@mkarmark @SatishRanjan
@calvinsID @JennyLawrance @sanchitmehta
CodeGen from PR 16506 in Azure/azure-rest-api-specs
b5d566c 
Web ant95 2021 03 01 (Azure#16506)

* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080)

* Update StaticSites.json

* Update StaticSites.json

* Onedeploy API swapper spec (Azure#15985)

* Onedeploy API swapper spec

* Adding onedeploy custom keyword

* Formatting onedeploy api indentation

Formatting onedeploy api indentation

* prettifier

Co-authored-by: Calvin Chan <[email protected]>

* Fix status codes for syncfunctiontriggers (Azure#16413)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web

* Fix duplicate operation ids

* Swagger for ASD Transfer out (Azure#16000)

* Add domain transfer out to swagger

* Prettifier

* Add 202 response for webapp restart

* Add certificate listHostnameBindingsOfCertificate

* Formatting

* Swagger for listHostnameBindings endpoint (Azure#16516)

* Swagger for listHostnameBindings endpoint

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* ops

Co-authored-by: Naveed Aziz <[email protected]>

* User/jennylaw/containerapp (Azure#16657)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Add custom hostname sites endpoint (Azure#16745)

* Add custom hostname sites endpoint

* Fix models

* Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger

* Fix sercret read property

* Prettier fix

* Model fix

* Prettier Fix #2

Co-authored-by: Jenny Lawrance <[email protected]>

* Add long running extension for restart (Azure#16791)

* Remove unused API from ANT95 swagger (Azure#16901)

* Address PR comments (Azure#17019)

* Fixing PR comments (Azure#17127)

* Remove Certificate Hostname bindings API (Azure#17204)

* Remove Certificate Hostname bindings API

* Remove examples file as well

Co-authored-by: mkarmark <[email protected]>
Co-authored-by: SatishRanjan <[email protected]>
Co-authored-by: Calvin Chan <[email protected]>
Co-authored-by: Connor McMahon <[email protected]>
Co-authored-by: JennyLawrance <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] April
Development

Successfully merging a pull request may close this issue.

Make explicit that auth file is not supported anymore Azure/azure-sdk-for-python
2 participants
@lmazuel @mccoyp