Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous result for get_ftp_allowed and update_ftp_allowed method #16778

Closed
yuu045-ran opened this issue Feb 17, 2021 · 4 comments
Closed

Ambiguous result for get_ftp_allowed and update_ftp_allowed method #16778

yuu045-ran opened this issue Feb 17, 2021 · 4 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. Web Apps

Comments

@yuu045-ran
Copy link

yuu045-ran commented Feb 17, 2021

Describe the bug

We need further explaination on the get_ftp_allowed method as well as update_ftp_allowed method: which FTP state is it referring to, as well as how to verify this value in portal.

  • get_ftp_allowed will return true/false in the JSON but as far as I know, the FTP state(go to portal > app service > configuration > general settings > FTP state) actually should have 3 values:"AllAllowed", "Disabled", and "FtpsOnly". But get_ftp_allowed is returning boolean(only true/false) here:
{"name": "functionapp-name", 
"type":   "Microsoft.Web/sites",  
"allow": true}
  • In portal when we verify(az functionapp config show --name appname --resource-group rgname) the actual FTP state we will get "ftps_state": "Disabled", which is under type - "/subscriptions/{sub-id}/resourceGroups/{rgname}/providers/Microsoft.Web/sites/{app-name}/config/web"

  • In Azure resource explorer we can verify the same by clicking into app > config > web

It seems that the resource types are different(Microsoft.Web/sites, and Microsoft.Web/sites/{app-name}/config/web), but this is causing confusion and I think the get_ftp_allowed definition is ambiguous. So, in conclusion, we need what is the get_ftp_allowed method is returning and which FTP(FTP state?) is it referring to.

Expected behavior

Matching results between:

  • portal > app service > configuration > general settings > FTP state
  • result of running get_ftp_allowed

Or, explaination on what is the get_ftp_allowed is referring to.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 17, 2021
@xiangyan99 xiangyan99 added bug This issue requires a change to an existing behavior in the product in order to be resolved. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. Web Apps labels Feb 17, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @AzureAppServiceCLI, @antcp.

Issue Details

Describe the bug

We need further explaination on the get_ftp_allowed method as well as update_ftp_allowed method: which FTP state is it referring to, as well as how to verify this value in portal.

  • get_ftp_allowed will return true/false in the JSON but as far as I know, the FTP state(go to portal > app service > configuration > general settings > FTP state) actually should have 3 values:"AllAllowed", "Disabled", and "FtpsOnly". But get_ftp_allowed is returning boolean(only true/false) here:
{"name": "functionapp-name", 
"type":   "Microsoft.Web/sites",  
"allow": true}
  • In portal when we verify(az functionapp config show --name appname --resource-group rgname) the actual FTP state we will get "ftps_state": "Disabled", which is under type - "/subscriptions/{sub-id}/resourceGroups/{rgname}/providers/Microsoft.Web/sites/{app-name}/config/web"

  • In Azure resource explorer we can verify the same by clicking into app > config > web

It seems that the resource types are different(Microsoft.Web/sites, and Microsoft.Web/sites/{app-name}/config/web), but this is causing confusion and I think the get_ftp_allowed definition is ambiguous. So, in conclusion, we need what is the get_ftp_allowed method is returning and which FTP(FTP state?) is it referring to.

Expected behavior

Matching results between:

  • portal > app service > configuration > general settings > FTP state
  • result of running get_ftp_allowed

Or, explaination on what is the get_ftp_allowed is referring to.

Author: yuu045-ran
Assignees: -
Labels:

Mgmt, Service Attention, Web Apps, bug, customer-reported, needs-triage, question

Milestone: -

@xiangyan99 xiangyan99 removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Feb 17, 2021
@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@msyyc msyyc assigned 00Kai0 and unassigned msyyc Feb 18, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Dec 1, 2021
@RAY-316 RAY-316 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Dec 15, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Hi @yuu045-ran. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Dec 22, 2021

Hi @yuu045-ran, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Dec 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. Web Apps
Projects
None yet
Development

No branches or pull requests

5 participants