Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Graceful no-op for empty array input to certain methods #15211

Closed
yunhaoling opened this issue Nov 10, 2020 · 0 comments · Fixed by #15286
Closed

[ServiceBus] Graceful no-op for empty array input to certain methods #15211

yunhaoling opened this issue Nov 10, 2020 · 0 comments · Fixed by #15286
Assignees
@KieranBrantnerMagee
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] December

Comments

@yunhaoling
Copy link
Contributor

When passing an empty array to the following methods:

  • send_messages: empty message batch/ empty array
  • receiver_deferred_messages
  • cancel_schedule_messages
  • schedule_messages

The method should be a graceful no-op.
@yunhaoling yunhaoling added Service Bus Client This issue points to a problem in the data-plane of the library. labels Nov 10, 2020
@yunhaoling yunhaoling added this to the [2020] December milestone Nov 10, 2020
@yunhaoling yunhaoling added the blocking-release Blocks release label Nov 10, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Nov 10, 2020
KieranBrantnerMagee added a commit to KieranBrantnerMagee/azure-sdk-for-python that referenced this issue Nov 12, 2020
@KieranBrantnerMagee
Make send_messages, schedule_messages, cancel_scheduled_messages, and…
91cd7ee 
… receive_deferred_messages gracefully no-op when provided an empty list or empty batch (where appropriate). Adds tests and changelog notes for these scenarios. Closes Azure#15211
@KieranBrantnerMagee KieranBrantnerMagee mentioned this issue Nov 12, 2020
Merged
@ghost ghost closed this as completed in #15286 Nov 19, 2020
ghost pushed a commit that referenced this issue Nov 19, 2020
@KieranBrantnerMagee
[ServiceBus] Graceful noops for methods taking empty lists. (#15286)
9926619 
Make send_messages, schedule_messages, cancel_scheduled_messages, and receive_deferred_messages gracefully no-op when provided an empty list or empty batch (where appropriate).  Adds tests and changelog notes for these scenarios.  Closes #15211
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jul 16, 2021
CodeGen from PR 15211 in Azure/azure-rest-api-specs
8242aa0 
add stable version for hybrid network (Azure#15211)

* add stable - 1st commit

* add stable - 2nd commit

* add stable - 3rd commit

* add stable - 4th commit
RAY-316 pushed a commit that referenced this issue Aug 5, 2021
[AutoRelease] t2-hybridnetwork-2021-07-21-88671 (#19896)
d63dcf0 
* CodeGen from PR 15211 in Azure/azure-rest-api-specs
add stable version for hybrid network (#15211)

* add stable - 1st commit

* add stable - 2nd commit

* add stable - 3rd commit

* add stable - 4th commit

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] December
Development

Successfully merging a pull request may close this issue.

[ServiceBus] Graceful noops for methods taking empty lists. KieranBrantnerMagee/azure-sdk-for-python
2 participants
@KieranBrantnerMagee @yunhaoling