Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set authority from VS Code settings #14808

Closed
chlowell opened this issue Oct 27, 2020 · 0 comments · Fixed by #18846
Closed

Set authority from VS Code settings #14808

chlowell opened this issue Oct 27, 2020 · 0 comments · Fixed by #18846
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
Backlog

Comments

@chlowell
Copy link
Member

Users can configure VisualStudioCodeCredential's authority with the authority keyword argument, and this is necessary in all clouds save Public Cloud. This could instead be optional, because the credential could determine the correct authority from the user's VS Code settings by mapping the configured cloud name to an authority's URL. Other SDKs do this, for example in Java: https://github.com/Azure/azure-sdk-for-java/blob/d1c4f95452b289bb04ff749652bb41278832e4b0/sdk/identity/azure-identity/src/main/java/com/azure/identity/VisualStudioCodeCredential.java#L47
@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Oct 27, 2020
@chlowell chlowell added this to the Backlog milestone Oct 27, 2020
@chlowell chlowell mentioned this issue Oct 27, 2020
Merged
@chlowell chlowell mentioned this issue Apr 29, 2021
Closed
@chlowell chlowell mentioned this issue May 7, 2021
Closed
@chlowell chlowell mentioned this issue May 20, 2021
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jun 15, 2021
CodeGen from PR 14808 in Azure/azure-rest-api-specs
6cb00b4 
[trafficmanager]Update readme.python.md (Azure#14808)

* Update readme.python.md

* Update readme.md
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Read tenant and authority from VS Code user settings chlowell/azure-sdk-for-python
1 participant
@chlowell