Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] receive_messages parameter max message count default to 1 #14709

Closed
yunhaoling opened this issue Oct 22, 2020 · 2 comments · Fixed by #14939
Closed

[ServiceBus] receive_messages parameter max message count default to 1 #14709

yunhaoling opened this issue Oct 22, 2020 · 2 comments · Fixed by #14939
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Milestone
[2020] November

Comments

@yunhaoling
Copy link
Contributor

yunhaoling commented Oct 22, 2020 •
edited by KieranBrantnerMagee
Loading

Currently, peek_messages defaults to a max_message_count of 1. receive_messages does not. (currently None).

This was a historical artifact from T1 wherein it would fall back to using the prefetch value if one was defined. We will be normalizing with a more clear semantic for T2 of having 1 for all consistently as a default
@yunhaoling yunhaoling added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 22, 2020
@yunhaoling yunhaoling added this to the [2020] November milestone Oct 22, 2020
@yunhaoling yunhaoling changed the title [ServiceBus] received_messages parameter max message count default to 1 [ServiceBus] receive_messages parameter max message count default to 1 Oct 22, 2020
@ramya-rao-a ramya-rao-a added blocking-release Blocks release help wanted This issue is tracking work for which community contributions would be welcomed and appreciated labels Oct 22, 2020
@stefpiatek
Copy link
Contributor

I'm happy to do create a PR for this if you'd like?

@KieranBrantnerMagee
Copy link
Member

Hey @stefpiatek , that sounds excellent, feel free to take a stab at this.

Should be reasonably straightforward, with the minor callouts to adjust docstrings accordingly and ensure async + sync.

Don't hesitate to give us a shout if you needed any eyes/hands/thoughts, and thanks in advance!

@stefpiatek stefpiatek mentioned this issue Oct 31, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jun 10, 2021
CodeGen from PR 14709 in Azure/azure-rest-api-specs
eacd4d0 
java mgmt, aks, add needed json (Azure#14709)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jun 10, 2021
CodeGen from PR 14709 in Azure/azure-rest-api-specs
213da71 
java mgmt, aks, add needed json (Azure#14709)
msyyc pushed a commit that referenced this issue Jun 18, 2021
[AutoRelease] t1-containerservice-2021-06-17-42969 (#19291)
d84085d 
* CodeGen from PR 14709 in Azure/azure-rest-api-specs
java mgmt, aks, add needed json (#14709)

* version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
msyyc pushed a commit that referenced this issue Jun 21, 2021
@RAY-316
[AutoRelease] t2-containerservice-2021-06-17-11581 (#19292)
fae3605 
* CodeGen from PR 14709 in Azure/azure-rest-api-specs
java mgmt, aks, add needed json (#14709)

* version,CHANGELOG

* test

* test config

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Projects
None yet
Milestone
[2020] November
4 participants
@stefpiatek @ramya-rao-a @KieranBrantnerMagee @yunhaoling