Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Vault Administration Readme issues #14027

Closed
v-xuto opened this issue Sep 25, 2020 · 0 comments · Fixed by #14068
Closed

Key Vault Administration Readme issues #14027

v-xuto opened this issue Sep 25, 2020 · 0 comments · Fixed by #14068
Assignees
@chlowell @mccoyp
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Milestone
[2020] October

Comments

@v-xuto
Copy link
Member

v-xuto commented Sep 25, 2020

Section link1, link2, link3, link4:
image

Suggestion:
Add hyperlink for Code of Conduct FAQ https://opensource.microsoft.com/codeofconduct/faq/

Section link1, link2:
image

Reason:
NameError: name 'KeyVaultRoleScope' is not defined.

Suggestion:
Update from azure.keyvault.administration import KeyVaultAccessControlClient
to: from azure.keyvault.administration import KeyVaultAccessControlClient, KeyVaultRoleScope

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Sep 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 25, 2020
@lmazuel lmazuel added this to the [2020] October milestone Sep 26, 2020
@lmazuel lmazuel added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Sep 26, 2020
@chlowell chlowell mentioned this issue Sep 28, 2020
Merged
@ghost ghost closed this as completed in #14068 Sep 28, 2020
ghost pushed a commit that referenced this issue Sep 28, 2020
@chlowell
Update Key Vault readmes (#14068)
eb141f3 
Closes #14027.
- link to Code of Conduct FAQ
- add missing import to administration samples
- correct impressions links (%2FF -> %2F)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

@mccoyp mccoyp

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Docs KeyVault test-manual-pass
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

Update Key Vault readmes chlowell/azure-sdk-for-python
5 participants
@lmazuel @chlowell @tzhanl @mccoyp @v-xuto