-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_size_in_mega_bytes vs max_size_in_megabytes #14
Comments
Verified as fixed. |
AutorestCI
added a commit
that referenced
this issue
Jun 21, 2019
Merge pull request #14 from moreOver0/conhua/ad_updates resolve review comment
beltr0n
pushed a commit
to beltr0n/azure-sdk-for-python
that referenced
this issue
Jan 23, 2021
Bertong extract identity
wonder6845
pushed a commit
to wonder6845/azure-sdk-for-python
that referenced
this issue
Aug 21, 2022
[keyvault] style: format to f-string samples/backup_restore_operations.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There is an inconsistency in the library for this field name. It is used in service bus Topic and Queue classes. In one, it uses max_size_in_mega_bytes, in the other it’s max_size_in_megabytes.
In addition to the inconsistency, there is a bug in the convert_topic_to_xml function:
I propose we use max_size_in_megabytes everywhere for the field name. The HowTo guides for Topic and Queue are both showing code examples that use max_size_in_megabytes (so one of the guides is currently wrong).
The text was updated successfully, but these errors were encountered: