AdministratorName parameter should take value which is defined in enum (

#7377) * AdministratorName parameter should take constant value defined in enum * Code review fixes * Code review fixes * Fix tabs and spaces * Fix example with get * revert example with get * Fix examples
Azure · Nov 7, 2019 · 5e95a31 · 5e95a31
1 parent 80a458c
commit 5e95a31
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 9 deletions.
diff --git a/...Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorCreate.json b/...Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorCreate.json
@@ -18,7 +18,6 @@
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-        "location": "southeastasia",
         "name": "ActiveDirectory",
         "properties": {
           "administratorType": "ActiveDirectory",
@@ -32,7 +31,6 @@
     "201": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-        "location": "southeastasia",
         "name": "ActiveDirectory",
         "properties": {
           "administratorType": "ActiveDirectory",

diff --git a/...er/Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorGet.json b/...er/Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorGet.json
@@ -10,7 +10,6 @@
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-        "location": "southeastasia",
         "name": "ActiveDirectory",
         "properties": {
           "administratorType": "ActiveDirectory",

diff --git a/...t.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorListByInstance.json b/...t.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorListByInstance.json
@@ -11,7 +11,6 @@
         "value": [
           {
             "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-            "location": "southeastasia",
             "name": "ActiveDirectory",
             "properties": {
               "administratorType": "ActiveDirectory",

diff --git a/...Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorUpdate.json b/...Microsoft.Sql/preview/2017-03-01-preview/examples/ManagedInstanceAdministratorUpdate.json
@@ -18,7 +18,6 @@
     "200": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-        "location": "southeastasia",
         "name": "ActiveDirectory",
         "properties": {
           "administratorType": "ActiveDirectory",
@@ -32,7 +31,6 @@
     "201": {
       "body": {
         "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/Default-SQL-SouthEastAsia/providers/Microsoft.Sql/managedInstances/managedInstance/administrators/ActiveDirectory",
-        "location": "southeastasia",
         "name": "ActiveDirectory",
         "properties": {
           "administratorType": "ActiveDirectory",

diff --git a/...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/managedInstanceAdministrators.json b/...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/managedInstanceAdministrators.json
@@ -77,7 +77,13 @@
             "in": "path",
             "description": "The administrator name.",
             "required": true,
-            "type": "string"
+            "type": "string",
+            "enum": [
+              "ActiveDirectory"
+            ],
+            "x-ms-enum": {
+              "name": "AdministratorName"
+            }
           },
           {
             "$ref": "#/parameters/SubscriptionIdParameter"
@@ -121,7 +127,13 @@
             "in": "path",
             "description": "The requested administrator name.",
             "required": true,
-            "type": "string"
+            "type": "string",
+            "enum": [
+              "ActiveDirectory"
+            ],
+            "x-ms-enum": {
+              "name": "AdministratorName"
+            }
           },
           {
             "name": "parameters",
@@ -187,7 +199,13 @@
             "in": "path",
             "description": "The administrator name.",
             "required": true,
-            "type": "string"
+            "type": "string",
+            "enum": [
+              "ActiveDirectory"
+            ],
+            "x-ms-enum": {
+              "name": "AdministratorName"
+            }
           },
           {
             "$ref": "#/parameters/SubscriptionIdParameter"