[Key Vault] Update tests to work with missing SP credentials (#36679)

Azure · Jul 30, 2024 · 4b50745 · 4b50745
1 parent 92bf9ab
commit 4b50745
Show file tree

Hide file tree

Showing 14 changed files with 26 additions and 20 deletions.
diff --git a/sdk/keyvault/azure-keyvault-administration/tests/_async_test_case.py b/sdk/keyvault/azure-keyvault-administration/tests/_async_test_case.py
@@ -48,9 +48,9 @@ def _skip_if_not_configured(self, api_version, **kwargs):
 
     def _set_mgmt_settings_real_values(self):
         if self.is_live:
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
-            os.environ["AZURE_CLIENT_SECRET"] = os.environ["KEYVAULT_CLIENT_SECRET"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
 
 class KeyVaultBackupClientPreparer(BaseClientPreparer):

diff --git a/sdk/keyvault/azure-keyvault-administration/tests/_test_case.py b/sdk/keyvault/azure-keyvault-administration/tests/_test_case.py
@@ -49,9 +49,9 @@ def _skip_if_not_configured(self, api_version, **kwargs):
 
     def _set_mgmt_settings_real_values(self):
         if self.is_live:
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
-            os.environ["AZURE_CLIENT_SECRET"] = os.environ["KEYVAULT_CLIENT_SECRET"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
 
 class KeyVaultBackupClientPreparer(BaseClientPreparer):

diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/_async_test_case.py b/sdk/keyvault/azure-keyvault-certificates/tests/_async_test_case.py
@@ -28,8 +28,8 @@ def __init__(self, **kwargs) -> None:
         self.is_logging_enabled = kwargs.pop("logging_enable", True)
 
         if is_live():
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
             os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def __call__(self, fn):

diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/_test_case.py b/sdk/keyvault/azure-keyvault-certificates/tests/_test_case.py
@@ -26,8 +26,8 @@ def __init__(self, **kwargs) -> None:
 
         if is_live():
             self.azure_keyvault_url = os.environ["AZURE_KEYVAULT_URL"]
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
             os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def __call__(self, fn):

diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates.py b/sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates.py
@@ -21,6 +21,7 @@ def print(*args):
     assert all(arg is not None for arg in args)
 
 
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 def test_create_certificate_client():
     vault_url = "vault_url"
     # pylint:disable=unused-variable

diff --git a/sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates_async.py b/sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates_async.py
@@ -21,6 +21,7 @@ def print(*args):
 
 
 @pytest.mark.asyncio
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 async def test_create_certificate():
     vault_url = "vault_url"
     # pylint:disable=unused-variable

diff --git a/sdk/keyvault/azure-keyvault-keys/tests/_async_test_case.py b/sdk/keyvault/azure-keyvault-keys/tests/_async_test_case.py
@@ -95,9 +95,9 @@ def create_key_client(self, vault_uri, **kwargs):
 
     def _set_mgmt_settings_real_values(self):
         if self.is_live:
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
-            os.environ["AZURE_CLIENT_SECRET"] = os.environ.get("KEYVAULT_CLIENT_SECRET", "")  # Empty for user auth
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def _skip_if_not_configured(self, is_hsm):
         if self.is_live and is_hsm and self.managed_hsm_url is None:

diff --git a/sdk/keyvault/azure-keyvault-keys/tests/_test_case.py b/sdk/keyvault/azure-keyvault-keys/tests/_test_case.py
@@ -100,9 +100,9 @@ def create_key_client(self, vault_uri, **kwargs):
 
     def _set_mgmt_settings_real_values(self):
         if self.is_live:
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
-            os.environ["AZURE_CLIENT_SECRET"] = os.environ.get("KEYVAULT_CLIENT_SECRET", "")  # Empty for user auth
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def _skip_if_not_configured(self, is_hsm):
         if self.is_live and is_hsm and self.managed_hsm_url is None:

diff --git a/sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys.py b/sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys.py
@@ -23,6 +23,7 @@ def print(*args):
     assert all(arg is not None for arg in args)
 
 
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 def test_create_key_client():
     vault_url = "vault_url"
     # pylint:disable=unused-variable

diff --git a/sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys_async.py b/sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys_async.py
@@ -21,6 +21,7 @@ def print(*args):
 
 
 @pytest.mark.asyncio
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 async def test_create_key_client():
     vault_url = "vault_url"
     # pylint:disable=unused-variable

diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/_async_test_case.py b/sdk/keyvault/azure-keyvault-secrets/tests/_async_test_case.py
@@ -18,8 +18,8 @@ def __init__(self, **kwargs) -> None:
 
         self.is_logging_enabled = kwargs.pop("logging_enable", True)
         if is_live():
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
             os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def __call__(self, fn):

diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/_test_case.py b/sdk/keyvault/azure-keyvault-secrets/tests/_test_case.py
@@ -24,8 +24,8 @@ def __init__(self, **kwargs) -> None:
 
         self.is_logging_enabled = kwargs.pop("logging_enable", True)
         if is_live():
-            os.environ["AZURE_TENANT_ID"] = os.environ["KEYVAULT_TENANT_ID"]
-            os.environ["AZURE_CLIENT_ID"] = os.environ["KEYVAULT_CLIENT_ID"]
+            os.environ["AZURE_TENANT_ID"] = os.getenv("KEYVAULT_TENANT_ID", "")  # empty in pipelines
+            os.environ["AZURE_CLIENT_ID"] = os.getenv("KEYVAULT_CLIENT_ID", "")  # empty in pipelines
             os.environ["AZURE_CLIENT_SECRET"] = os.getenv("KEYVAULT_CLIENT_SECRET", "")  # empty for user-based auth
 
     def __call__(self, fn):

diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/test_samples_secrets.py b/sdk/keyvault/azure-keyvault-secrets/tests/test_samples_secrets.py
@@ -19,6 +19,7 @@ def print(*args):
     assert all(arg is not None for arg in args)
 
 
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 def test_create_secret_client():
     vault_url = "vault_url"
     # pylint:disable=unused-variable

diff --git a/sdk/keyvault/azure-keyvault-secrets/tests/test_samples_secrets_async.py b/sdk/keyvault/azure-keyvault-secrets/tests/test_samples_secrets_async.py
@@ -22,6 +22,7 @@ def print(*args):
 
 
 @pytest.mark.asyncio
+@pytest.mark.playback_test_only("Can't run in live pipelines, and there's no reason to.")
 async def test_create_secret_client():
     vault_url = "vault_url"
     # pylint:disable=unused-variable