update 412 handler and tests

Azure · Sep 10, 2019 · 30c63ac · 30c63ac
1 parent 6f13c4a
commit 30c63ac
Show file tree

Hide file tree

Showing 9 changed files with 72 additions and 66 deletions.
diff --git a/...onfiguration/_generated/aio/operations_async/_azure_app_configuration_operations_async.py b/...onfiguration/_generated/aio/operations_async/_azure_app_configuration_operations_async.py
@@ -333,16 +333,16 @@ async def get_key_value(self, key, label=None, accept_datetime=None, if_match=No
         if accept_datetime is not None:
             header_parameters['Accept-Datetime'] = self._serialize.header("accept_datetime", accept_datetime, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.get(url, query_parameters, header_parameters)
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 304, 404, 412]:
+        if response.status_code not in [200, 304, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -407,9 +407,9 @@ async def put_key_value(self, key, label=None, entity=None, if_match=None, if_no
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct body
         if entity is not None:
@@ -422,7 +422,7 @@ async def put_key_value(self, key, label=None, entity=None, if_match=None, if_no
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 412]:
+        if response.status_code not in [200]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -480,14 +480,14 @@ async def delete_key_value(self, key, label=None, if_match=None, *, cls=None, **
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
 
         # Construct and send request
         request = self._client.delete(url, query_parameters, header_parameters)
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 204, 412]:
+        if response.status_code not in [200, 204]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -556,16 +556,16 @@ async def check_key_value(self, key, label=None, accept_datetime=None, if_match=
         if accept_datetime is not None:
             header_parameters['Accept-Datetime'] = self._serialize.header("accept_datetime", accept_datetime, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.head(url, query_parameters, header_parameters)
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 304, 404, 412]:
+        if response.status_code not in [200, 304, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise HttpResponseError(response=response)
 
@@ -755,16 +755,16 @@ async def put_lock(self, key, label=None, if_match=None, if_none_match=None, *,
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.put(url, query_parameters, header_parameters)
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 404, 412]:
+        if response.status_code not in [200, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -825,16 +825,16 @@ async def delete_lock(self, key, label=None, if_match=None, if_none_match=None,
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.delete(url, query_parameters, header_parameters)
         pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 404, 412]:
+        if response.status_code not in [200, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 

diff --git a/...ation/azure/appconfiguration/_generated/operations/_azure_app_configuration_operations.py b/...ation/azure/appconfiguration/_generated/operations/_azure_app_configuration_operations.py
@@ -332,16 +332,16 @@ def get_key_value(self, key, label=None, accept_datetime=None, if_match=None, if
         if accept_datetime is not None:
             header_parameters['Accept-Datetime'] = self._serialize.header("accept_datetime", accept_datetime, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.get(url, query_parameters, header_parameters)
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 304, 404, 412]:
+        if response.status_code not in [200, 304, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -406,9 +406,9 @@ def put_key_value(self, key, label=None, entity=None, if_match=None, if_none_mat
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct body
         if entity is not None:
@@ -421,7 +421,7 @@ def put_key_value(self, key, label=None, entity=None, if_match=None, if_none_mat
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 412]:
+        if response.status_code not in [200]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -479,14 +479,14 @@ def delete_key_value(self, key, label=None, if_match=None, cls=None, **kwargs):
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
 
         # Construct and send request
         request = self._client.delete(url, query_parameters, header_parameters)
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 204, 412]:
+        if response.status_code not in [200, 204]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -555,16 +555,16 @@ def check_key_value(self, key, label=None, accept_datetime=None, if_match=None,
         if accept_datetime is not None:
             header_parameters['Accept-Datetime'] = self._serialize.header("accept_datetime", accept_datetime, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.head(url, query_parameters, header_parameters)
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 304, 404, 412]:
+        if response.status_code not in [200, 304, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise HttpResponseError(response=response)
 
@@ -753,16 +753,16 @@ def put_lock(self, key, label=None, if_match=None, if_none_match=None, cls=None,
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.put(url, query_parameters, header_parameters)
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 404, 412]:
+        if response.status_code not in [200, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 
@@ -823,16 +823,16 @@ def delete_lock(self, key, label=None, if_match=None, if_none_match=None, cls=No
         if self._config.sync_token is not None:
             header_parameters['Sync-Token'] = self._serialize.header("self._config.sync_token", self._config.sync_token, 'str')
         if if_match is not None:
-            header_parameters['If-Match'] = self._serialize.header("if_match", if_match, 'str')
+            header_parameters['if-match'] = self._serialize.header("if_match", if_match, 'str')
         if if_none_match is not None:
-            header_parameters['If-None-Match'] = self._serialize.header("if_none_match", if_none_match, 'str')
+            header_parameters['if-none-match'] = self._serialize.header("if_none_match", if_none_match, 'str')
 
         # Construct and send request
         request = self._client.delete(url, query_parameters, header_parameters)
         pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
         response = pipeline_response.http_response
 
-        if response.status_code not in [200, 404, 412]:
+        if response.status_code not in [200, 404]:
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise models.ErrorException(response, self._deserialize)
 

diff --git a/...ion/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py b/...ion/azure-appconfiguration/azure/appconfiguration/aio/azure_configuration_client_async.py
@@ -278,6 +278,9 @@ async def update_configuration_setting(
             label=label
         )
 
+        if key_value is None:
+            return None
+
         if value is not None:
             key_value.value = value
         content_type = kwargs.get("content_type")

diff --git a/...figuration/azure-appconfiguration/azure/appconfiguration/azure_appconfiguration_client.py b/...figuration/azure-appconfiguration/azure/appconfiguration/azure_appconfiguration_client.py
@@ -267,6 +267,9 @@ def update_configuration_setting(
             label=label
         )
 
+        if key_value is None:
+            return None
+
         if value is not None:
             key_value.value = value
         content_type = kwargs.get("content_type")

diff --git a/sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/models.py b/sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/models.py
@@ -54,6 +54,8 @@ def __init__(self, **kwargs):
     def _from_key_value(cls, key_value):
         # type: (_models.KeyValue) -> ConfigurationSetting
         """Construct a DeletedKey from an autorest-generated DeletedKeyBundle"""
+        if key_value is None:
+            return None
         return cls(
             key=key_value.key,
             label=key_value.label,

diff --git a/sdk/appconfiguration/azure-appconfiguration/examples/test_example_configurationservice.py b/sdk/appconfiguration/azure-appconfiguration/examples/test_example_configurationservice.py
@@ -94,14 +94,14 @@ def test_appconfig_client_sample(self):
         # [START list_configuration_setting]
         from datetime import datetime, timedelta
 
-        accept_date_time = datetime.today() + timedelta(days=-1)
+        accept_datetime = datetime.today() + timedelta(days=-1)
 
         all_listed = client.list_configuration_settings()
         for item in all_listed:
             pass  # do something
 
         filtered_listed = client.list_configuration_settings(
-            labels=["*Labe*"], keys=["*Ke*"], accept_date_time=accept_date_time
+            labels=["*Labe*"], keys=["*Ke*"], accept_datetime=accept_datetime
         )
         for item in filtered_listed:
             pass  # do something
@@ -110,14 +110,14 @@ def test_appconfig_client_sample(self):
         # [START list_revisions]
         from datetime import datetime, timedelta
 
-        accept_date_time = datetime.today() + timedelta(days=-1)
+        accept_datetime = datetime.today() + timedelta(days=-1)
 
         all_revisions = client.list_configuration_settings()
         for item in all_revisions:
             pass  # do something
 
         filtered_revisions = client.list_revisions(
-            labels=["*Labe*"], keys=["*Ke*"], accept_date_time=accept_date_time
+            labels=["*Labe*"], keys=["*Ke*"], accept_datetime=accept_datetime
         )
         for item in filtered_revisions:
             pass  # do something

diff --git a/sdk/appconfiguration/azure-appconfiguration/tests/app_config_asynctests/async_proxy.py b/sdk/appconfiguration/azure-appconfiguration/tests/app_config_asynctests/async_proxy.py
@@ -29,11 +29,11 @@ def __init__(self, obj):
         self.obj = obj
 
     def get_configuration_setting(
-        self, key, label=None, accept_date_time=None, **kwargs
+        self, key, label=None, accept_datetime=None, **kwargs
     ):
         return get_event_loop().run_until_complete(
             self.obj.get_configuration_setting(
-                key, label=label, accept_date_time=accept_date_time, **kwargs
+                key, label=label, accept_datetime=accept_datetime, **kwargs
             )
         )
 
@@ -48,24 +48,24 @@ def delete_configuration_setting(self, key, label=None, etag=None, **kwargs):
         )
 
     def list_configuration_settings(
-        self, labels=None, keys=None, accept_date_time=None, fields=None, **kwargs
+        self, labels=None, keys=None, accept_datetime=None, fields=None, **kwargs
     ):
         paged = self.obj.list_configuration_settings(
             labels=labels,
             keys=keys,
-            accept_date_time=accept_date_time,
+            accept_datetime=accept_datetime,
             fields=fields,
             **kwargs
         )
         return _to_list(paged)
 
     def list_revisions(
-        self, labels=None, keys=None, accept_date_time=None, fields=None, **kwargs
+        self, labels=None, keys=None, accept_datetime=None, fields=None, **kwargs
     ):
         paged = self.obj.list_revisions(
             labels=labels,
             keys=keys,
-            accept_date_time=accept_date_time,
+            accept_datetime=accept_datetime,
             fields=fields,
             **kwargs
         )