Update EnvironmentCredential and EnvironmentVariables #9430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaabs
reviewed
Feb 21, 2020
| @@ -59,13 +59,19 @@ internal EnvironmentCredential(CredentialPipeline pipeline) | |||
| string username = EnvironmentVariables.Username; | |||
| string password = EnvironmentVariables.Password; | |||
| string sdkAuthLocation = EnvironmentVariables.SdkAuthLocation; | |||
| string clientCertificatePath = EnvironmentVariables.ClientCertificatePath; | |||
| var clientCertificate = new X509Certificate2(clientCertificatePath); | |||
There was a problem hiding this comment.
The X509Certificate2 should only be instantiated in the if block below.
else if (clientCertificate != null)
{
var clientCertificate = new X509Certificate2(clientCertificatePath);
_credential = new ClientCertificateCredential(tenantId, clientId, clientCertificate, _pipeline);
}
|
I think this was covered as part of #10196 |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the AZURE_CLIENT_CERTIFICATE_PATH to EnvironmentVariables, and update the EnvironmentCredential to support AZURE_CLIENT_CERTIFICATE_PATH