[Event Hubs Client] Track Two (Timer Dispose Fix) #9156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
kinelski,
AlexGhiondea,
serkantkaraca and
ShivangiReja
jsquire
commented
Dec 16, 2019
jsquire
commented
Dec 16, 2019
| @@ -754,6 +754,11 @@ protected virtual TimeSpan CalculateLinkAuthorizationRefreshInterval(DateTime ex | |||
|
|
|||
| try | |||
| { | |||
| if (refreshTimer == null) | |||
There was a problem hiding this comment.
Note: This will help reduce the potential for occurrence, but does not eliminate it as the Dispose call could be taking place as the timer callback is invoked.
The focus of these changes is to address a race condition that could cause the authorization refresh timer callback to throw an ObjectDisposedException due to a set of benign race conditions. These changes attempt to make those conditions less likely but cannot elimitate them completely without introducing synchronization overhead. Because the condition is benign, accept the resulting exception as an expected case rather than paying that cost.
jsquire
force-pushed
the
eventhubs/amqpscope-timer-fix
branch
from
0c0261f to
36093bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to address a race condition that could cause the authorization refresh timer callback to throw an
ObjectDisposedExceptiondue to a set of benign race conditions. These changes attempt to make those conditions less likely but cannot eliminate them completely without introducing synchronization overhead. Because the condition is benign, accept the resulting exception as an expected case rather than paying that cost.Last Upstream Rebase
Monday, December 16, 3:18pm (EST)
Related and Follow-Up Issues