-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to MatchConditions per arch board. #8138
Updates to MatchConditions per arch board. #8138
Conversation
@@ -5,7 +5,7 @@ | |||
|
|||
namespace Azure | |||
{ | |||
public class ModifiedSinceConditions : MatchConditions | |||
public class RequestConditions : MatchConditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed the name change discussion, but why are we changing the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storage will be exposing this type several places in their public API. Calling it ModifiedSinceConditions is misleading because that makes it sound like it only contains If-Modified-Since and If-Unmodified-Since precondition headers, when it actually contains all the request conditions that we support in the SDK (all four of them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
But, I think RequestConditions is not ideal either. It sounds like a base type of all conditions, i.e. MatchConditions is also "request conditions". Also, I was hoping for these two types to end up close to each other in reference documentation (as their names both started with "M").
It's kind of late in the product cycle, so I am ok with merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another name you'd prefer?
Not doing (at this time):