Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to MatchConditions per arch board. #8138

Merged
merged 7 commits into from
Oct 16, 2019

Conversation

annelo-msft
Copy link
Member

@annelo-msft annelo-msft commented Oct 16, 2019

  • Remove SetIf*Condition() methods from MatchConditions
  • Rename ModifiedSinceConditions to RequestConditions

Not doing (at this time):

  • Implicit cast from ETag or DateTimeOffset
  • Support for multiple ETags in MatchConditions

@annelo-msft annelo-msft marked this pull request as ready for review October 16, 2019 16:44
@@ -5,7 +5,7 @@

namespace Azure
{
public class ModifiedSinceConditions : MatchConditions
public class RequestConditions : MatchConditions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed the name change discussion, but why are we changing the name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage will be exposing this type several places in their public API. Calling it ModifiedSinceConditions is misleading because that makes it sound like it only contains If-Modified-Since and If-Unmodified-Since precondition headers, when it actually contains all the request conditions that we support in the SDK (all four of them).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
But, I think RequestConditions is not ideal either. It sounds like a base type of all conditions, i.e. MatchConditions is also "request conditions". Also, I was hoping for these two types to end up close to each other in reference documentation (as their names both started with "M").

It's kind of late in the product cycle, so I am ok with merging this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another name you'd prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants