Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version info #8025

Merged
merged 8 commits into from
Oct 10, 2019
Merged

Update version info #8025

merged 8 commits into from
Oct 10, 2019

Conversation

leonardbf
Copy link
Contributor

@leonardbf leonardbf commented Oct 10, 2019

Changes in this version: #7704

@leonardbf leonardbf requested a review from erich-wang as a code owner October 10, 2019 12:54
@leonardbf
Copy link
Contributor Author

@yuemlu I made the version changes directly on the master branch of my fork. packageReleaseNotes were already updated but version in csproj was not. Also updated assemblyfileversion. Note that the diff of the PR shows all the files of the previous PR. I hope this is not a problem.

@isra-fel isra-fel self-assigned this Oct 10, 2019
@isra-fel
Copy link
Member

AzureApiTag in AzSdk.RP.props also needs to be updated, since you've change the api version

@isra-fel
Copy link
Member

Otherwise it looks good to me @leonardbf

@leonardbf
Copy link
Contributor Author

AzureApiTag in AzSdk.RP.props also needs to be updated, since you've change the api version

@isra-fel Ok, updated

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. Waiting for CI :shipit: labels Oct 10, 2019
@isra-fel isra-fel merged commit 96cfa0f into Azure:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants