Make Error model internal #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
amnguye,
seanmcc-msft and
tg-msft
as code owners
amnguye
approved these changes
Sep 26, 2019
tg-msft
approved these changes
Sep 26, 2019
JoshLove-msft
force-pushed
the
make-error-internal
branch
from
cfd0a03 to
b8ff90f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error type is only used within DatalakeStorageError which is already marked as internal. However, the generated code still makes Error public which exposes it in our API and causes the creation of the factory method, which we don't want.