Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN package base on Latest Swagger #7723

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Conversation

hytao
Copy link
Contributor

@hytao hytao commented Sep 23, 2019

Regenerated SDK package base on latest CDN swagger.
Feature Added:
UrlRewrite and CacheKeyQueryString Action for RulesEngine.

@hytao hytao requested a review from erich-wang as a code owner September 23, 2019 19:44
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hytao , the changes generally look good to me. However the metadata txt is in the wrong path -- should be eng\mgmt\mgmtmetadata\<rpName>.txt.

This could be caused by out-dated build tools. Could you try rebuilding the tools by msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules, then run generate.ps1 again?

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Sep 24, 2019
@hytao
Copy link
Contributor Author

hytao commented Sep 24, 2019

Hi @isra-fel , I have re-built the tool and re-run the generate.ps1. However, I did not see any change in metadata txt. Do you know other way to fix the problem? Is it possible to fix it manually?

@hytao hytao removed their assignment Sep 24, 2019
@isra-fel
Copy link
Member

I'm sorry, it seems no only the path is wrong, so is the content. I'm trying to figure out what is the cause. Will get back to you soon. Thanks

@isra-fel
Copy link
Member

OK I got it now. Instead of using generate.cmd, please create a generate.ps1 file containing

Start-AutoRestCodeGeneration -ResourceProvider "cnd/resource-manager" -AutoRestVersion "latest"

Run the script and you'll get everything right 😁
BTW please delete old generate.cmd

Thanks

@hytao
Copy link
Contributor Author

hytao commented Sep 25, 2019

I have regenerated SDK with generate.ps1. Thanks

@hytao hytao removed their assignment Sep 25, 2019
This file was generated by `.cmd` which we no longer use. So deleted it.
@isra-fel
Copy link
Member

Removed the metadata txt under src/

@isra-fel isra-fel merged commit f6adfc2 into Azure:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants