-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnableStyleCopStorage #7701
Merged
chidozieononiwu
merged 6 commits into
Azure:master
from
chidozieononiwu:EnableStyleCopStorage
Sep 26, 2019
Merged
EnableStyleCopStorage #7701
chidozieononiwu
merged 6 commits into
Azure:master
from
chidozieononiwu:EnableStyleCopStorage
Sep 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
requested review from
amnguye,
seanmcc-msft and
tg-msft
as code owners
September 20, 2019 00:31
chidozieononiwu
changed the title
Turn on StyleCop and fix resulting errors
EnableStyleCopStorage
Sep 20, 2019
tg-msft
approved these changes
Sep 20, 2019
@@ -31,9 +31,7 @@ public void Upload() | |||
// obtain your connection string from the Azure Portal (click | |||
// Access Keys under Settings in the Portal Storage account blade) | |||
// or using the Azure CLI with: | |||
// | |||
// az storage account show-connection-string --name <account_name> --resource-group <resource_group> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we chatted about - I like these lines to help make the shell command clearer.
amnguye
approved these changes
Sep 24, 2019
chidozieononiwu
force-pushed
the
EnableStyleCopStorage
branch
from
September 25, 2019 21:17
c969e4b
to
79055ee
Compare
…le header copyright text should match in generated code
chidozieononiwu
force-pushed
the
EnableStyleCopStorage
branch
from
September 25, 2019 21:27
79055ee
to
34af711
Compare
chidozieononiwu
force-pushed
the
EnableStyleCopStorage
branch
from
September 25, 2019 21:34
34af711
to
5c0c62c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.