Implement CryptographyClient with EC support #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run net - core - ci |
|
Pull request contains merge conflicts. |
Also adds additional validation based on DiagnosticScope.
Discussed various ideas but they had deeper adverse effects on runtime code that I feel is too risky. We have plenty of coverage elsewhere for ES256K in general across non-macOS platforms. We really don't need it here.
schaabs
approved these changes
Sep 20, 2019
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/EcCryptographyClient.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/LocalCryptographyClientFactory.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/RsaCryptographyClient.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/SignatureAlgorithm.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7518
This adds test for CryptographyClient for the EC crypto provider. I will add more tests with the RSA provider once the overall structure is approved.