Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage - echo client request id #7644

Merged
merged 2 commits into from
Sep 18, 2019
Merged

storage - echo client request id #7644

merged 2 commits into from
Sep 18, 2019

Conversation

amnguye
Copy link
Member

@amnguye amnguye commented Sep 17, 2019 •
edited by seanmcc-msft
Loading

Resolves #6997

tg-msft
tg-msft reviewed Sep 17, 2019
View reviewed changes
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments about a few small things. I'll pull it locally to see if I can dig into those bizarre test issues.

sdk/storage/Azure.Storage.Blobs/tests/BlobTestBase.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/src/StorageRequestValidationPipelinePolicy.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/src/StorageRequestValidationPipelinePolicy.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/src/StorageRequestValidationPipelinePolicy.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/src/StorageClientOptions.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/src/StorageRequestValidationPipelinePolicy.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/tests/Shared/RecordedClientRequestIdPolicy.cs Outdated Show resolved Hide resolved
sdk/storage/Azure.Storage.Common/tests/Shared/RecordedClientRequestIdPolicy.cs Outdated Show resolved Hide resolved
@amnguye amnguye marked this pull request as ready for review September 17, 2019 19:15
@amnguye amnguye force-pushed the storage/feature/echo-client-request-id-2 branch from 071d73a to a89455a Compare September 17, 2019 23:17
@seanmcc-msft seanmcc-msft merged commit f2ec379 into Azure:master Sep 18, 2019
@amnguye amnguye deleted the storage/feature/echo-client-request-id-2 branch May 29, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmcc-msft seanmcc-msft seanmcc-msft approved these changes

@tg-msft tg-msft tg-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Echo Client Request ID
3 participants
@amnguye @tg-msft @seanmcc-msft