Disable content logging by default #7633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
requested review from
tg-msft,
jsquire,
schaabs,
annelo-msft and
heaths
tg-msft
approved these changes
Sep 17, 2019
|
|
||
| public static readonly LoggingPolicy Shared = new LoggingPolicy(); |
There was a problem hiding this comment.
Is it worth having SharedNoContent and SharedWithContent?
There was a problem hiding this comment.
I suspect it would have more parameters pretty soon
heaths
approved these changes
Sep 17, 2019
| @@ -92,19 +98,19 @@ private static async Task ProcessAsync(HttpPipelineMessage message, ReadOnlyMemo | |||
|
|
|||
| var textResponse = ContentTypeUtilities.TryGetTextEncoding(message.Response.Headers.ContentType, out Encoding? responseTextEncoding); | |||
|
|
|||
| bool wrapResponseStream = message.Response.ContentStream != null && message.Response.ContentStream?.CanSeek == false && s_eventSource.ShouldLogContent(isError); | |||
| bool logResponseContent = _logContent && message.Response.ContentStream != null; | |||
| bool wrapResponseContent = logResponseContent && message.Response.ContentStream?.CanSeek == false && s_eventSource.ShouldLogContent(isError); | |||
There was a problem hiding this comment.
You can check the generated IL, but at least when targeting net45 my old code base had to change a lot of this syntax not to use the Elvis operator when comparing against value types. It causes extra allocations. Just separate check if ContentStream != null prior.
In a frequent code path, this could add up (it did in our case).
There was a problem hiding this comment.
I checked, the Elvis doesn't result in allocation and produces almost identical IL and asm
KrzysztofCwalina
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7559