-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyVault Certificates adding README and samples #7629
Conversation
Thread.Sleep(newCertOp.PollingInterval); | ||
} | ||
|
||
// The certificate is no longer needed, need to delete it from the Key Vault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two separate sentences.
public partial class GetCertificates | ||
{ | ||
[Test] | ||
public async Task GetKeysAsync() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetCertificatesAsync
?
# Azure Key Vault Certificate client library for .NET | ||
Azure Key Vault is a cloud service that provides secure storage and automated management of certificates used throughout a cloud application. Multiple certificate, and multiple versions of the same certificate, can be kept in the Key Vault. Each certificate in the vault has a policy associated with it which controls the issuance and lifetime of the certificate, along with actions to be taken as certificates near expiry. | ||
|
||
The Azure Key Vault Certificate client library enables programmatically managing certificates, offering methods to create, update, list and delete certificates, policies, issuers and contacts. The library also supports managing pending certificate operations, and management of deleted certificates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I recommend the Oxford comma everywhere for readability. It helps separate clauses, which is especially important with complex list statements such as this.
az keyvault show --name <your-key-vault-name> | ||
``` | ||
|
||
#### Create KeyClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CertificateClient
### Create a Certificate | ||
`StartCreateCertificate` creates a Certificate to be stored in the Azure Key Vault. If a certificate with | ||
the same name already exists, then a new version of the certificate is created. | ||
When creating the certificate the user can specify the policy which controls the certificate lifetime. If no policy is speicired the default policy will be used. The `StartCreateCertificate` operation returns a `CertificateOperation`. The following example creates a self signed certificate with the default policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"specified"
``` | ||
|
||
### Delete a Certificate | ||
`delete_certificate` deletes all versions of a certificate stored in the Key Vault. When [soft-delete][soft_delete] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeleteCertificate
## Troubleshooting | ||
|
||
### General | ||
When you interact with the Azure Key Vault Key client library using the .NET SDK, errors returned by the service correspond to the same HTTP status codes returned for [REST API][keyvault_rest] requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Certificate Client"
### General | ||
When you interact with the Azure Key Vault Key client library using the .NET SDK, errors returned by the service correspond to the same HTTP status codes returned for [REST API][keyvault_rest] requests. | ||
|
||
For example, if you try to retrieve a Key that doesn't exist in your Key Vault, a `404` error is returned, indicating `Not Found`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Certificate". I'll not repeat this comment (may be more). I'm seeing a lot of (copy and paste?) references to Key Client and Keys.
``` | ||
## Next steps | ||
Key Vault Certificates client library samples are available to you in this GitHub repository. These samples provide example code for additional scenarios commonly encountered while working with Key Vault: | ||
* [HelloWorld.cs][hello_world_sync] and [HelloWorldAsync.cs][hello_world_async] - for working with Azure Key Vault, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links aren't defined below.
/azp run net - keyvault - ci Rerunning pipeline due to issue #7604 |
No pipelines are associated with this pull request. |
/azp run net - keyvault - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.