Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory] Update SDK from swagger. #7582

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Conversation

mdo98
Copy link
Contributor

@mdo98 mdo98 commented Sep 12, 2019

  • Enable Databricks warm pools.

@mdo98 mdo98 requested a review from erich-wang as a code owner September 12, 2019 01:29
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mdo98 , could you

  • Add a link to the orginal spec review PR in the description
  • Add the .txt file generated when you run generate.ps1(details)
  • Update versions, tags, if necessary
  • and did you forget to update changelog?

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Sep 12, 2019
@mdo98 mdo98 requested a review from AlexGhiondea as a code owner September 13, 2019 19:37
@mdo98 mdo98 removed their assignment Sep 13, 2019
@mdo98
Copy link
Contributor Author

mdo98 commented Sep 13, 2019

@isra-fel @AlexGhiondea @erich-wang Addressed your comments and resolved conflict; please approve and merge asap; we need to release this today.

@hvermis
Copy link
Contributor

hvermis commented Sep 13, 2019

@isra-fel @AlexGhiondea @erich-wang For ADF please do not ask individual developers to update the version. I do our releases, and it I always end up changing, since the numbers they put are usually wrong. Last version for ADF SDK was 4.1.2, so this one should be 4.1.3.
For reference: https://www.nuget.org/packages/Microsoft.Azure.Management.DataFactory/

@mdo98
Copy link
Contributor Author

mdo98 commented Sep 13, 2019

@isra-fel @AlexGhiondea @erich-wang By the way the command in the generate.ps1 is incomplete. I had to use the following command.
powershell -Command "& {Start-AutoRestCodeGeneration -ResourceProvider datafactory/resource-manager -AutoRestVersion latest -ConfigFileTag package-2018-06 -SdkRepoRootPath E:\src\repos\github\mdo98\azure-sdk-for-net\sdk }"

Also, the error message from running the command is also wrong. It advised users to add the -SdkRepoPath parameter, but the correct parameter is -SdkRepoRootPath.

@mdo98 mdo98 requested a review from isra-fel September 14, 2019 00:57
@@ -3,12 +3,12 @@ AutoRest installed successfully.
Commencing code generation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .txt should be under eng\mgmt\mgmtmetadata\

@erich-wang
Copy link
Member

@isra-fel @AlexGhiondea @erich-wang By the way the command in the generate.ps1 is incomplete. I had to use the following command.
powershell -Command "& {Start-AutoRestCodeGeneration -ResourceProvider datafactory/resource-manager -AutoRestVersion latest -ConfigFileTag package-2018-06 -SdkRepoRootPath E:\src\repos\github\mdo98\azure-sdk-for-net\sdk }"

Also, the error message from running the command is also wrong. It advised users to add the -SdkRepoPath parameter, but the correct parameter is -SdkRepoRootPath.

@mdo98, have you followed the detail instruction to pull latest code and installpsmodules? And use new PS console and navigate to the folder your generate.ps1? You don't need to specify SdkRepoRootPath if you follow the instruction.

@hvermis
Copy link
Contributor

hvermis commented Sep 16, 2019

@erich-wang, can you please merge this? We need to release our SDK, and we are waiting for this change.

@hvermis
Copy link
Contributor

hvermis commented Sep 17, 2019

@isra-fel @AlexGhiondea @erich-wang Can someone please review and merge this ASAP? This is delaying our release schedule.

@weshaggard
Copy link
Member

@isra-fel @erich-wang looks like the feedback has been addressed and this is blocking their release so I'm assisting @hvermis by merging this PR. If there are additional things that need to be address we can do that in a later PR.

@weshaggard weshaggard merged commit 4ac2114 into Azure:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants