-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory] Update SDK from swagger. #7582
Conversation
mdo98
commented
Sep 12, 2019
- Enable Databricks warm pools.
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isra-fel @AlexGhiondea @erich-wang Addressed your comments and resolved conflict; please approve and merge asap; we need to release this today. |
@isra-fel @AlexGhiondea @erich-wang For ADF please do not ask individual developers to update the version. I do our releases, and it I always end up changing, since the numbers they put are usually wrong. Last version for ADF SDK was 4.1.2, so this one should be 4.1.3. |
@isra-fel @AlexGhiondea @erich-wang By the way the command in the generate.ps1 is incomplete. I had to use the following command. Also, the error message from running the command is also wrong. It advised users to add the -SdkRepoPath parameter, but the correct parameter is -SdkRepoRootPath. |
@@ -3,12 +3,12 @@ AutoRest installed successfully. | |||
Commencing code generation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This .txt should be under eng\mgmt\mgmtmetadata\
@mdo98, have you followed the detail instruction to pull latest code and installpsmodules? And use new PS console and navigate to the folder your generate.ps1? You don't need to specify SdkRepoRootPath if you follow the instruction. |
@erich-wang, can you please merge this? We need to release our SDK, and we are waiting for this change. |
@isra-fel @AlexGhiondea @erich-wang Can someone please review and merge this ASAP? This is delaying our release schedule. |
@isra-fel @erich-wang looks like the feedback has been addressed and this is blocking their release so I'm assisting @hvermis by merging this PR. If there are additional things that need to be address we can do that in a later PR. |