Style Checking for Core #7581
Merged
Style Checking for Core #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
force-pushed
the
StyleCheckingForCore
branch
2 times, most recently
from
a812edd to
319b99e
Compare
pakrym
reviewed
Sep 12, 2019
| @@ -43,7 +43,7 @@ internal sealed class HttpPipelineEventSource : EventSource | |||
|
|
|||
| private HttpPipelineEventSource() : base(EventSourceName) { } | |||
|
|
|||
| internal static readonly HttpPipelineEventSource Singleton = new HttpPipelineEventSource(); | |||
| internal static readonly HttpPipelineEventSource s_singleton = new HttpPipelineEventSource(); | |||
There was a problem hiding this comment.
This needs to be a property.
pakrym
reviewed
Sep 12, 2019
| @@ -45,8 +47,10 @@ public async Task UpdateStatusAsync() | |||
| var testResult = 100; | |||
| var testResponse = new MockResponse(200); | |||
|
|
|||
| var operation = new TestOperation<int>("operation-id", TimeSpan.FromMilliseconds(10), testResult, testResponse); | |||
| operation.UpdateCalled = () => { updateCalled++; }; | |||
| var operation = new TestOperation<int>("operation-id", TimeSpan.FromMilliseconds(10), testResult, testResponse) | |||
There was a problem hiding this comment.
This expanded 2 lines into 4, what controls this behavior?
There was a problem hiding this comment.
This is due to dotnet_style_object_initializer = true:suggestion
There was a problem hiding this comment.
I guess it's fine, fix the HttpPipelineEventSource s_singleton and I think everything else is ok.
chidozieononiwu
force-pushed
the
StyleCheckingForCore
branch
from
319b99e to
1cac0f9
Compare
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chidozieononiwu what was the reason for the build failure? Can you link the issue please? |
Its due to this issue #7490 |
chidozieononiwu
force-pushed
the
StyleCheckingForCore
branch
from
1cac0f9 to
faadce8
Compare
pakrym
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update .editorconfig from dotnet/corefx /.editorconfig
Fix code style to adhere to editorconfig rules