Unify argument validation into shared source class #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
requested changes
Sep 11, 2019
There was a problem hiding this comment.
LGTM. I asked for a couple of small changes, mostly around formatting, for internal consistency within the Event Hubs library.
Event Hubs has a release related to preview 3 due this week, and I'd like to request that this not be merged until we've passed that milestone. I'm tagging "Request Changes" only to prevent an unintended merge beforehand; I don't see any blockers otherwise.
sdk/eventhub/Azure.Messaging.EventHubs/tests/Authorization/SharedAccessSignatureTests.cs
Show resolved
Hide resolved
heaths
force-pushed
the
issue7547
branch
2 times, most recently
from
444144e to
c364344
Compare
|
/azp run net - keyvault - ci Transient failure in Microsoft.Azure.EventHubs.Tests.ServiceFabricProcessor.OptionsTests.RuntimeInformationTest again. |
|
No pipelines are associated with this pull request. |
|
/azp run net - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
approved these changes
Sep 16, 2019
Will help prevent "possible null" errors later when we enable nullability for code that uses this class.
Forgot to update this project in another solution.
heaths
added a commit
to heaths/azure-sdk
that referenced
this pull request
Sep 20, 2019
Relates to Azure/azure-sdk-for-net#7547 and should be merged only after PR Azure/azure-sdk-for-net#7569 is merged.
heaths
added a commit
to Azure/azure-sdk
that referenced
this pull request
Sep 24, 2019
* Add guideline about using a common argument validator Relates to Azure/azure-sdk-for-net#7547 and should be merged only after PR Azure/azure-sdk-for-net#7569 is merged. * Resolve PR feedback * Move implementation details to separate page This is similar to what other languages do. Added the jekyll-relative-links plugin, which is documented to be supported by GitHub already anyway.
bterlson
pushed a commit
to bterlson/azure-sdk
that referenced
this pull request
Apr 16, 2020
* Add guideline about using a common argument validator Relates to Azure/azure-sdk-for-net#7547 and should be merged only after PR Azure/azure-sdk-for-net#7569 is merged. * Resolve PR feedback * Move implementation details to separate page This is similar to what other languages do. Added the jekyll-relative-links plugin, which is documented to be supported by GitHub already anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7547. For now, this only updates EventHub, but the PR will be updated to update KeyVault in which, for another PR (#7563) included a copy. @schaabs did have some concerns about what this does to the stack, but it does help keep the exceptions consistent, i.e.
ArgumentNullExceptionfor null andArgumentExceptionfor empty strings, which is consistent with the Framework (example).