Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New kusto version (2019-05-15) #7542

Merged
merged 6 commits into from
Sep 16, 2019
Merged

New kusto version (2019-05-15) #7542

merged 6 commits into from
Sep 16, 2019

Conversation

shdavido
Copy link
Contributor

@shdavido shdavido commented Sep 9, 2019 •
edited
Loading

This PR is for adding the new kusto version (2019-05-15) to our C# client SDK

Link to the orginal spec review PR:
Azure/azure-rest-api-specs#6690

@shdavido shdavido requested a review from erich-wang as a code owner September 9, 2019 21:06
isra-fel
isra-fel approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shdavido , could you

  • Add a link to the orginal spec review PR in the description
  • Follow the instructions here to generate code, and track the .txt file
  • Update versions, tags, if necessary
  • Resolve the failed tests

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Sep 10, 2019
isra-fel
isra-fel suggested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't have approved... Change back to "request changes"

@shdavido
Copy link
Contributor Author

shdavido commented Sep 12, 2019 •
edited
Loading

Hi,

  1. Done
  2. Added the txt file to the PR, also changes versions as described.

But in stage 4: PackageTags , PackageReleaseNotes , can i leave them the same? i don't see a reason to change them. If PackageTags must be changed, can i add some version to it?

  1. Done
  2. When i run the tests on my branch, they pass and succeed, Can someone help me to understand why it's failed here?

@erich-wang erich-wang merged commit 2c8b25e into Azure:master Sep 16, 2019
@AlexGhiondea AlexGhiondea mentioned this pull request Oct 7, 2019
Closed
15 tasks
@heaths heaths mentioned this pull request Oct 29, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel requested changes

@erich-wang erich-wang erich-wang approved these changes

Assignees

@shdavido shdavido

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shdavido @isra-fel @erich-wang