Instrument event processor #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Sep 7, 2019
sdk/eventhub/Azure.Messaging.EventHubs/src/Processor/PartitionPump.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Sep 7, 2019
jsquire
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
There was a recent work stream for preview 3 that made some non-trivial changes to a lot of the Event Processor surface; you're likely to hit some conflicts, but I think the areas that you're in shouldn't have been too badly impacted.
I left a couple of notes to ask for Doc comments for internal consistency with the surrounding library code. If you're in a rush, let me know and I don't mind circling back to add them in.
sdk/eventhub/Azure.Messaging.EventHubs/src/Diagnostics/EventDataInstrumentation.cs
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Diagnostics/EventDataInstrumentation.cs
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/tests/Diagnostics/DiagnosticsTests.cs
Show resolved
Hide resolved
pakrym
commented
Sep 9, 2019
lmolkova
approved these changes
Sep 9, 2019
pakrym
commented
Sep 9, 2019
| @@ -6,6 +6,7 @@ | |||
| <PackageReleaseNotes>https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/eventhub/Azure.Messaging.EventHubs/CHANGELOG.md</PackageReleaseNotes> | |||
| <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks> | |||
| <EnableFxCopAnalyzers>false</EnableFxCopAnalyzers> | |||
| <UseProjectReferenceToAzureCore>true</UseProjectReferenceToAzureCore> | |||
There was a problem hiding this comment.
Temporary until we ship preview 3
jsquire
requested changes
Sep 11, 2019
jsquire
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instrumentation for EventProcessor processing and checkpoints
Fixes: #7554