Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datafactory] Office 365 - Added outputColumns property to Office365Source #7507

Merged
merged 2 commits into from
Sep 6, 2019
Merged

[Datafactory] Office 365 - Added outputColumns property to Office365Source #7507

merged 2 commits into from
Sep 6, 2019

Conversation

davidzhaoyue
Copy link
Contributor

@davidzhaoyue davidzhaoyue commented Sep 6, 2019 •
edited
Loading

isra-fel
isra-fel suggested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidzhaoyue , could you please

  1. Put a link to the swagger pr in description
  2. Track the .txt file generated when you run generate.ps1 (detailed steps here: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#sdk-generation-from-updated-spec)
  3. Update the versions in AssemblyInfo.cs

Thanks

@isra-fel isra-fel added the Mgmt This issue is related to a management-plane library. label Sep 6, 2019
@isra-fel isra-fel merged commit f5a2438 into Azure:master Sep 6, 2019
JoshLove-msft pushed a commit to JoshLove-msft/azure-sdk-for-net that referenced this pull request Sep 10, 2019
@davidzhaoyue @JoshLove-msft
[Datafactory] Office 365 - Added outputColumns property to Office365S…
665807e 
…ource (Azure#7507)

* [Datafactory] Office 365 - Added outputColumns property to Office365Source

* Resolve review comments
@davidzhaoyue davidzhaoyue deleted the Office365_public branch November 6, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@davidzhaoyue davidzhaoyue

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidzhaoyue @isra-fel