Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matching for skipped headers #7483

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Fix matching for skipped headers #7483

merged 2 commits into from
Sep 6, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Sep 5, 2019

And don't leak the listener in case of exceptions.

@pakrym pakrym requested a review from tg-msft September 5, 2019 18:26
@pakrym
Copy link
Contributor Author

pakrym commented Sep 5, 2019

Automatically checking if the client is instrumented is hard and noisy, unfortunately.

tg-msft
tg-msft approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this. Mind holding off on the merge until I can get the Storage tests patched?

@pakrym
Copy link
Contributor Author

pakrym commented Sep 5, 2019

Sure.

@pakrym pakrym merged commit f21ca17 into Azure:master Sep 6, 2019
JoshLove-msft pushed a commit to JoshLove-msft/azure-sdk-for-net that referenced this pull request Sep 10, 2019
@pakrym @JoshLove-msft
Fix matching for skipped headers (Azure#7483)
0c5ce95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg-msft tg-msft tg-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pakrym @tg-msft