Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Factory] Adding Chaining Trigger #7469

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

haricr
Copy link
Contributor

@haricr haricr commented Sep 4, 2019

Adding new feature Chaining Trigger

Swagger Spec PR - Azure/azure-rest-api-specs#7076

@haricr haricr requested a review from erich-wang as a code owner September 4, 2019 03:18
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @haricr could you

  • Add a link to the orginal spec review PR in the description
  • Add the .txt file generated when you run generate.ps1(details)
  • Update versions, tags, if necessary

Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Sep 4, 2019
@haricr
Copy link
Contributor Author

haricr commented Sep 10, 2019

Hi @haricr could you

Add a link to the orginal spec review PR in the description
Add the .txt file generated when you run generate.ps1(details)
Update versions, tags, if necessary

Thanks

I added the Link and verified don't need version update. While running generate.ps1.. I get an error
PS E:\GitHub\azure-sdk-for-net\sdk\datafactory\Microsoft.Azure.Management.DataFactory\src> .\generate.ps1
Start-AutoRestCodeGeneration : Could not find root for output directory since script is not run from SDK repo, please
provide this using the -SdkRepoPath parameter!

If I try to pass the parameter .. It does not work. Can you please help

@isra-fel
Copy link
Member

@haricr
That looks strange 🤔 You didn't copy the file out of SDK directory, did you?
Could you try just double click or right-click and choose "Run with PowerShell"?
The last choice is to specify -SdkRepoRootPath "$PSScriptRoot\..\..\..\..", be sure to point to the right folder.

@haricr
Copy link
Contributor Author

haricr commented Sep 11, 2019

@haricr
That looks strange 🤔 You didn't copy the file out of SDK directory, did you?
Could you try just double click or right-click and choose "Run with PowerShell"?
The last choice is to specify -SdkRepoRootPath "$PSScriptRoot........", be sure to point to the right folder.

Thanks... passing -SdkRepoRootPath worked.. Updated the review

@isra-fel isra-fel merged commit 29841c3 into Azure:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants