Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close child entities when client is closed. #7443

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Close child entities when client is closed. #7443

merged 2 commits into from
Aug 30, 2019

Conversation

serkantkaraca
Copy link
Member

@serkantkaraca serkantkaraca commented Aug 30, 2019 •
edited
Loading

Wiring up close call on the EventHubClient to close underlying child entities. This also fixes failing Close tests.

#7435

@serkantkaraca serkantkaraca added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Aug 30, 2019
@serkantkaraca serkantkaraca merged commit b4291d8 into Azure:master Aug 30, 2019
@serkantkaraca serkantkaraca deleted the serkar.CloseChildEntities branch August 12, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBirdsall JamesBirdsall JamesBirdsall approved these changes

@jsquire jsquire Awaiting requested review from jsquire

@kinelski kinelski Awaiting requested review from kinelski

@sjkwak sjkwak Awaiting requested review from sjkwak

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serkantkaraca @JamesBirdsall