Ignore live-only tests when in Playback or Record modes #7430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially fixes Azure#7416
heaths
requested review from
kfarmer-msft,
seanmcc-msft and
tg-msft
as code owners
pakrym
reviewed
Aug 30, 2019
| /// <summary> | ||
| /// Attribute on test assemblies, classes, or methods that run only against live resources. | ||
| /// </summary> | ||
| [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class | AttributeTargets.Assembly, AllowMultiple = true, Inherited = true)] |
There was a problem hiding this comment.
Originally it wasn't, but since samples are often split across partial classes - both of which were attributed with [Category("Live")] - I did this to be able to attribute both classes as well. It shouldn't hurt anything, though I'm totally willing to disallow multiple and remove it from one class (probably the sync classes, since async is better to use/recommend).
|
LGTM |
tg-msft
approved these changes
Sep 3, 2019
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-sdk-for-net
that referenced
this pull request
Sep 10, 2019
Fixes Azure#7416 * Ignore live-only tests when in Playback or Record modes * Attribute to other live-only tests throughout repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #7416. This is currently only applied to keyvault but would be applied to other services once the design is approved.
This ignores live-only tests when not using live test mode, which then doesn't simply cause live tests (like samples) to fail, potentially even taking some time before they do since they may partially run.
As you can see from the screenshot, a reason is given, and "Live" is still emitted as a category. I just made a single attribute to do that all for ease.