Enable StyleCop Analyzer #7424
Enable StyleCop Analyzer #7424
Conversation
chidozieononiwu
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
|
/azp run net - client - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -45,6 +45,7 @@ | |||
| <IsTestSupportProject Condition="'$(IsTestProject)' != 'true' and ($(MSBuildProjectDirectory.Contains('/tests/')) or $(MSBuildProjectDirectory.Contains('\tests\')))">true</IsTestSupportProject> | |||
| <EnableClientSdkAnalyzers Condition="'$(IsClientLibrary)' == 'true' and '$(IsTestProject)' != 'true' and '$(IsTestSupportProject)' != 'true' and '$(IsSamplesProject)' != 'true'">true</EnableClientSdkAnalyzers> | |||
| <EnableFxCopAnalyzers Condition="'$(IsClientLibrary)' == 'true' and '$(IsTestProject)' != 'true' and '$(IsTestSupportProject)' != 'true' and '$(IsSamplesProject)' != 'true'">true</EnableFxCopAnalyzers> | |||
| <CodeAnalysisRuleSet>$(RepoEngPath)\CodeAnalysis.ruleset</CodeAnalysisRuleSet> | |||
There was a problem hiding this comment.
You might want to consider adding a condition here if you expect some folks might need to opt-out. Although it is hard to opt-out of a setting in the props file because it is imported before any properties in a project can be set, but we should figure out an opt-out strategy.
There was a problem hiding this comment.
Opt out will be done by simply removing the package reference from the specific project.
There was a problem hiding this comment.
My expectation is that the package reference would be would be in the common targets file similar to the other tools packages like SourceLink, as opposed to being in each of the projects. Although you are correct you can condition the project references for projects that want to opt-out.
Enable Style Cop with all rules disabled