Fix failure in doc.yml #7405
Fix failure in doc.yml #7405
Conversation
chidozieononiwu
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
| @@ -7,33 +7,23 @@ | |||
| <PropertyGroup> | |||
| <ECMA2YmlVersion>1.0.644-alpha</ECMA2YmlVersion> | |||
| <PopImportVersion>1.0.0</PopImportVersion> | |||
| <BclAsyncInterfacesVersion>1.0.0-preview8.19405.3</BclAsyncInterfacesVersion> | |||
| <NETStandardVersion>2.0.2</NETStandardVersion> | |||
There was a problem hiding this comment.
I believe you are still going to need the netstandard package.
There was a problem hiding this comment.
Turns out the whole net-standard is not necessary.
eng/pipelines/docs.yml
Outdated
| SourceFolder: '$(Build.ArtifactStagingDirectory)/dll-output' | ||
| TargetFolder: '$(Build.BinariesDirectory)/dll-docs/my-api' | ||
| SourceFolder: "$(Build.ArtifactStagingDirectory)/dll-output" | ||
| TargetFolder: "$(Build.BinariesDirectory)/dll-docs/my-api" |
There was a problem hiding this comment.
Why do we need this copy? There shouldn't be anything else in that directory.
There was a problem hiding this comment.
It contains .pdb and .json files which are not needed.
There was a problem hiding this comment.
If those don't hurt anything then I'd leave them otherwise I would delete the not needed files as opposed to making yet another copy.
There was a problem hiding this comment.
I have updated that.
chidozieononiwu
force-pushed
the
FixDocYmlFailure
branch
2 times, most recently
from
73a7288 to
4a6783a
Compare
| contents: | | ||
| *.dll | ||
| *.xml | ||
| SourceFolder: "$(Build.BinariesDirectory)/dll-docs/my-api" |
There was a problem hiding this comment.
Again I'd only bother deleting these if they cause some sort of issue, otherwise I wouldn't introduce the potential failure point.
| @@ -31,18 +31,20 @@ jobs: | |||
| displayName: "Use .NET Core sdk $(DotNetCoreSDKVersion)" | |||
| inputs: | |||
| version: $(DotNetCoreSDKVersion) | |||
There was a problem hiding this comment.
You should still remove https://github.com/Azure/azure-sdk-for-net/blob/master/eng/docgeneration/assets/docgen.csproj#L25 as part of this update.
There was a problem hiding this comment.
I have it updated now. Thanks for pointing it out
chidozieononiwu
force-pushed
the
FixDocYmlFailure
branch
from
4a6783a to
84b5676
Compare
chidozieononiwu
force-pushed
the
FixDocYmlFailure
branch
from
84b5676 to
4bb2328
Compare
No description provided.