Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Version 2019-08-01-preview #7314

Closed
wants to merge 3 commits into from
Closed

API Version 2019-08-01-preview #7314

wants to merge 3 commits into from

Conversation

rileymckenna
Copy link
Contributor

Added Peering Service to SDK
Added Tests to support new service

isra-fel
isra-fel suggested changes Aug 18, 2019
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rileymckenna , seems there are some CI errors. Could you fix them then request a review?

Besides, please put a link to the swagger review PR in comments, and follow the instructions here and make sure you git add the generated eng\mgmt\mgmtmetadata\<rpName>.txt.

@isra-fel
Copy link
Member

Oh and I would highly recommend keep the commit history clean. Here is how to

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-revision labels Aug 18, 2019
@rileymckenna rileymckenna reopened this Aug 19, 2019
@rileymckenna rileymckenna removed their assignment Aug 19, 2019
@rileymckenna
Copy link
Contributor Author

@isra-fel I rebased and passing tests. Awaiting ARM this is staged.

@rileymckenna
Copy link
Contributor Author

Can one of the admins verify this patch?

@rileymckenna
Copy link
Contributor Author

@isra-fel ARM signed off on PR.

@isra-fel
Copy link
Member

Hey @rileymckenna , just one thing -- please also check in the generated eng\mgmt\mgmtmetadata\<rpName>.txt in PR. Thanks

@rileymckenna rileymckenna reopened this Aug 23, 2019
@isra-fel
Copy link
Member

isra-fel commented Aug 26, 2019 •
edited
Loading

@rileymckenna I have some questions:

  • Why did you delete resources_resource-manager.txt -- generation log for another module (I believe there might be some merging problem)
  • There shouldn't be a peering_resource-manager.txt inside src/SDKs/_metadata/, if you generate your code by running generate.ps1, it should appear in eng/mgmt/mgmtmetadata/

Thanks

@rileymckenna rileymckenna reopened this Aug 26, 2019
@rileymckenna
Copy link
Contributor Author

closing and reopening. failed to squash changes properly to master.

@rileymckenna rileymckenna mentioned this pull request Aug 26, 2019
Merged
@AlexGhiondea
Copy link
Contributor

The current PR touches 3.4k files -- could you please make sure you rebase on master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel requested changes

@erich-wang erich-wang Awaiting requested review from erich-wang

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@jsquire jsquire Awaiting requested review from jsquire

@kalyanaj kalyanaj Awaiting requested review from kalyanaj

@kfarmer-msft kfarmer-msft Awaiting requested review from kfarmer-msft

@kinelski kinelski Awaiting requested review from kinelski

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@schaabs schaabs Awaiting requested review from schaabs

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

@tg-msft tg-msft Awaiting requested review from tg-msft

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileymckenna @isra-fel @AlexGhiondea