-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding .Net SDK support for setting Azure AD administrator on Managed Instance #7243
Conversation
…e files are automatically generated based on json file. And there is written test for these operationnew operations.
…MI. These files are automatically generated based on json file. And there is written test for these operationnew operations." This reverts commit caf83b0.
…dmin on MI. These files are automatically generated based on json file. And there is written test for these operationnew operations."" This reverts commit f8ee73e.
…e files are automatically generated based on json file. And there is written test for these operationnew operations. Exclude .history folder
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @SanjaMalesevic , please provide the corresponding Spec review PR, and also please follow these instructions when you generate .Net SDK. Thanks.
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
This changes for .NET client are generated using managedInstanceAdministrators.json from PR Azure/azure-rest-api-specs#5095. |
Hi, I've just added comment above with link to corresponding PR on azure-rest-api-specs branch. |
Hi @SanjaMalesevic , there are some test failures. Please fix them then assign the PR back to me. Thanks |
I made some changes in creating vnet, new route is added there. So, I need to record all test that create vnet and add new session records. Because of that build has failed. Execution takes lot of time, so I couldn't finish today and I will be out of office next week. It will be solved for 10 days. |
Syncing from original
Recent PR Azure#7243 bumped version to 1.34 and added release notes, but old release notes from 1.33 are still there and should be removed before 1.34 is released.
Recent PR #7243 bumped version to 1.34 and added release notes, but old release notes from 1.33 are still there and should be removed before 1.34 is released.
No description provided.