Move Id to Operation<T> and hide CopyFromUriOperation #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
requested review from
pakrym,
KrzysztofCwalina,
kfarmer-msft and
seanmcc-msft
pakrym
reviewed
Jul 31, 2019
| /// Gets an ID representing the operation that can be used to poll for | ||
| /// the status of the LRO. | ||
| /// </summary> | ||
| public string Id => _id; |
KrzysztofCwalina
approved these changes
Aug 1, 2019
and quieting down some flaky tests (Azure#7077)
Forcing consumers to have an ID is nice, let's see if it holds. |
tg-msft
added a commit
that referenced
this pull request
Aug 1, 2019
I missed the default ctor when adding Id as part of #7068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
Idproperty up toOperation<T>so we don't need to expose our ownCopyFromUriOperationjust to provide theId.Removing
CopyFromUriOperationis a breaking change:Before: Use
CopyFromUriOperationAfter: Use
Operation<long>@KrzysztofCwalina and @pakrym -- please weigh in on whether the
protected ctoris fine or we'd rather have a settable property./fyi @seanmcc-msft @kfarmer-msft @amnguye