Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Search] Update indexer and ServiceStats limits #7031

Merged
merged 3 commits into from
Jul 29, 2019
Merged

[Azure Search] Update indexer and ServiceStats limits #7031

merged 3 commits into from
Jul 29, 2019

Conversation

enjaimes
Copy link
Contributor

No description provided.

@enjaimes enjaimes requested a review from erich-wang as a code owner July 25, 2019 23:19
@enjaimes enjaimes changed the title Update indexer and ServiceStats limits [Azure Search] Update indexer and ServiceStats limits Jul 25, 2019
arv100kri
arv100kri requested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@arv100kri arv100kri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we deemed that this is a strictly binary breaking change from .NET code caller's perspective, let's not check this in yet, without revving a major version change

@enjaimes enjaimes requested a review from brjohnstmsft as a code owner July 29, 2019 22:14
@enjaimes enjaimes force-pushed the Update-Limits-Service-Stats-API branch from 01c295d to 8aaae0d Compare July 29, 2019 22:36
@arv100kri
Copy link
Member

Because we deemed that this is a strictly binary breaking change from .NET code caller's perspective, let's not check this in yet, without revving a major version change

Thanks @enjaimes for bumping up the major version!

@arv100kri arv100kri self-requested a review July 29, 2019 22:40
@weshaggard weshaggard merged commit afd697a into Azure:master Jul 29, 2019
@arv100kri arv100kri mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arv100kri arv100kri arv100kri approved these changes

@weshaggard weshaggard weshaggard approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

@danieljurek danieljurek Awaiting requested review from danieljurek

@brjohnstmsft brjohnstmsft Awaiting requested review from brjohnstmsft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enjaimes @arv100kri @weshaggard