Adding ChallengeCacheHandler to update challenge cache on 401 response #6950
Conversation
…es with auth challenge
…nto keyvault-challenge-cache-fix
|
|
||
| private static void AssertChallengeCacheEntry(string requestUrl, MockChallenge expChallenge) | ||
| { | ||
| var actChallenge = HttpBearerChallengeCache.GetInstance().GetChallengeForURL(new Uri(requestUrl)); |
There was a problem hiding this comment.
Are there any other tests these tests might conflict with when running in parallel?
There was a problem hiding this comment.
These shouldn't interfere with other tests as all the URLs that I'm using are guid based.
sdk/keyvault/Microsoft.Azure.KeyVault/tests/ChallengeCacheHandlerTests.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// A <see cref="DelegatingHandler"/> which will update the <see cref="HttpBearerChallengeCache"/> when a 401 response is returned with a WWW-Authenticate bearer challenge header. | ||
| /// </summary> | ||
| public class ChallengeCacheHandler : MessageProcessingHandler |
There was a problem hiding this comment.
I presume having the class public is intentional?
There was a problem hiding this comment.
Yes unfortunately. When constructing the key vault client the user has the option of giving us an HttpClient, in which case we our handler won't get added. So I made the class public so that users doing this would have a way to handle this bug. It's possible that I could have made it private and had users re-implement it, but I think this gives a better experience and also leaves us the ability to tweak the behavior.
fixes issue [BUG] Class KeyVaultCredential does not reflect change in www-authenticate header #5702