Update to a new analyzer package

eng/Packages.Data.props

@@ -9,7 +9,7 @@
   <ItemGroup>
     <PackageReference Update="ApprovalTests" Version="3.0.22" />
     <PackageReference Update="ApprovalUtilities" Version="3.0.22" />
-    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20190711.4" />
+    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20190716.1" />
     <PackageReference Update="Azure.Core" Version="1.0.0-preview.6" />
     <PackageReference Update="BenchmarkDotNet" Version="0.11.5" />
     <PackageReference Update="FsCheck.Xunit" Version="2.14.0" />

sdk/appconfiguration/Azure.ApplicationModel.Configuration/src/ConfigurationClient.cs

@@ -21,7 +21,6 @@ public partial class ConfigurationClient
         private readonly Uri _baseUri;
         private readonly HttpPipeline _pipeline;
 
-
         /// <summary>
         /// Protected constructor to allow mocking
         /// </summary>
@@ -304,7 +303,6 @@ public virtual async Task<Response<ConfigurationSetting>> UpdateAsync(string key
             return await UpdateAsync(new ConfigurationSetting(key, value, label), cancellationToken).ConfigureAwait(false);
         }
 
-
         /// <summary>
         /// Updates an existing <see cref="ConfigurationSetting"/> in the configuration store.
         /// </summary>

sdk/core/Azure.Core/src/Shared/HashCodeBuilder.cs

@@ -220,7 +220,6 @@ private static void Initialize(out uint v1, out uint v2, out uint v3, out uint v
         public static uint RotateLeft(uint value, int offset)
             => (value << offset) | (value >> (64 - offset));
 
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private static uint Round(uint hash, uint input)
         {

sdk/keyvault/Azure.Security.KeyVault.Certificates/src/IssuerBase.cs

@@ -14,6 +14,5 @@ public class IssuerBase
         public DateTimeOffset Created { get; set; }
         public DateTimeOffset Updated { get; set; }
         public bool Enabled { get; set; }
-
     }
 }

sdk/keyvault/Azure.Security.KeyVault.Keys/src/JsonWebKey.cs

@@ -237,7 +237,6 @@ internal override void WriteProperties(Utf8JsonWriter json)
             }
             if (N != null)
             {
-
                 json.WriteString(NPropertyNameBytes, Base64Url.Encode(N));
             }
             if (E != null)

sdk/keyvault/Azure.Security.KeyVault.Keys/src/KeyBase.cs

@@ -121,7 +121,7 @@ protected void ParseId(string id)
         }
 
         internal override void WriteProperties(Utf8JsonWriter json) { }
-        
+
         internal override void ReadProperties(JsonElement json)
         {
             foreach(JsonProperty prop in json.EnumerateObject())

sdk/keyvault/Azure.Security.KeyVault.Keys/src/KeyClientOptions.cs

@@ -14,14 +14,14 @@ public class KeyClientOptions : ClientOptions
     {
         /// <summary>
         /// The latest service version supported by this client library.
-        /// For more information, see 
+        /// For more information, see
         /// <see href="https://docs.microsoft.com/en-us/rest/api/keyvault/key-vault-versions"/>
         /// </summary>
         internal const ServiceVersion LatestVersion = ServiceVersion.V7_0;
 
         /// <summary>
         /// The versions of Azure Key Vault supported by this client
-        /// library. 
+        /// library.
         /// </summary>
         public enum ServiceVersion
         {
@@ -35,7 +35,7 @@ public enum ServiceVersion
 
         /// <summary>
         /// Gets the <see cref="ServiceVersion"/> of the service API used when
-        /// making requests. For more information, see 
+        /// making requests. For more information, see
         /// <see href="https://docs.microsoft.com/en-us/rest/api/keyvault/key-vault-versions"/>
         /// </summary>
         public ServiceVersion Version { get; }
@@ -46,13 +46,13 @@ public enum ServiceVersion
         /// </summary>
         /// <param name="version">
         /// The <see cref="ServiceVersion"/> of the service API used when
-        /// making requests. 
+        /// making requests.
         /// </param>
         public KeyClientOptions(ServiceVersion version = ServiceVersion.V7_0)
         {
             this.Version = version;
         }
-        
+
         internal string GetVersionString()
         {
             var version = string.Empty;

sdk/keyvault/Azure.Security.KeyVault.Keys/src/KeyRequestParameters.cs

@@ -150,6 +150,5 @@ internal override void WriteProperties(Utf8JsonWriter json)
         }
 
         internal override void ReadProperties(JsonElement json) { }
-
     }
 }

sdk/keyvault/Azure.Security.KeyVault.Keys/src/RsaKeyCreateOptions.cs

@@ -25,21 +25,20 @@ public class RsaKeyCreateOptions : KeyCreateOptions
         /// </summary>
         public int? KeySize { get; set; }
 
-        /// <summary> 
+        /// <summary>
         /// Determines whether or not a hardware key (HSM) is used for creation.
         /// </summary>
         ///
         /// <value><c>true</c> to use a hardware key; <c>false</c> to use a software key</value>
         public bool Hsm { get; private set; }
 
-
         /// <summary>
         /// Initializes a new instance of the RsaKeyCreateOptions class.
         /// </summary>
         /// <param name="name">The name of the key.</param>
         /// <param name="hsm">Whether to import as a hardware key (HSM) or software key.</param>
         /// <param name="keySize">Key size in bits.</param>
-        public RsaKeyCreateOptions(string name, bool hsm, int? keySize = null) 
+        public RsaKeyCreateOptions(string name, bool hsm, int? keySize = null)
         {
             Name = name;
             Hsm = hsm;

sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Page.cs

@@ -52,7 +52,6 @@ internal override void ReadProperties(JsonElement json)
                         i++;
                     }
                 }
-
             }
 
             if (json.TryGetProperty("nextLink", out JsonElement nextLink))
@@ -68,7 +67,7 @@ internal override void ReadProperties(JsonElement json)
 
         internal override void WriteProperties(ref Utf8JsonWriter json)
         {
-            // serialization is not needed this type is only in responses 
+            // serialization is not needed this type is only in responses
             throw new NotImplementedException();
         }
     }

sdk/keyvault/Azure.Security.KeyVault.Secrets/src/SecretBase.cs

@@ -36,7 +36,7 @@ public SecretBase(string name)
         /// Secret identifier.
         /// </summary>
         public Uri Id => _identifier.Id;
-        
+
         /// <summary>
         /// Vault base URL.
         /// </summary>
@@ -64,7 +64,7 @@ public SecretBase(string name)
         public bool? Managed { get; private set; }
 
         /// <summary>
-        /// If this is a secret backing a KV certificate, then this field specifies 
+        /// If this is a secret backing a KV certificate, then this field specifies
         /// the corresponding key backing the KV certificate.
         /// </summary>
         public string KeyId { get; private set; }