Storage test enhancements #6918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
requested review from
pakrym,
AlexGhiondea,
maririos,
kfarmer-msft,
seanmcc-msft,
schaabs and
jsquire
pakrym
approved these changes
Jul 16, 2019
- Change test recordings to not require a local config - Add an initial CONTRIBUTING.md - Add a test to garbage collect any resources in our test tenants
- Change the diagnostic attribute name - Use the same buffer size across platforms so recordings are in sync
pakrym
reviewed
Jul 19, 2019
pakrym
reviewed
Jul 19, 2019
pakrym
reviewed
Jul 19, 2019
|
I wish I've added more tests for this feature :( |
and be a little more careful about waiting for progress events
pakrym
approved these changes
Jul 19, 2019
(which should also help recordings across platforms)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Explicit]test to garbage collect any resources in our test tenantsPlease filter out all the
*.jsonfiles when reviewing. I had to re-record all of the tests to include the config.