Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs] Track Two: Second Preview (Diagnostics Tests) #6913

Merged
merged 23 commits into from
Jul 18, 2019

Conversation

kinelski
Copy link
Member

These changes adapt existing Track One Diagnostics Tests into Track Two code.

Related issue: #6793

@kinelski kinelski added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jul 12, 2019
@kinelski kinelski self-assigned this Jul 12, 2019
@mitchdenny
Copy link
Contributor

/azp run net - eventhub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kinelski kinelski marked this pull request as ready for review July 17, 2019 10:23
@kinelski kinelski requested a review from jsquire July 17, 2019 10:23
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nothing else, I've learned that I'm both a horrible typist and speller by reading this. I shall now go hang my head in shame.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! I left a couple of very minor nits, and an ask to open an issue for some future enhancements.

:shipit:

@kinelski kinelski merged commit 4280c4b into Azure:master Jul 18, 2019
@kinelski kinelski deleted the diag branch August 15, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants