Storage API Changes (Part 2 - Simplify the Storage user experience) #6749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
requested review from
pakrym,
AlexGhiondea,
KrzysztofCwalina,
kfarmer-msft,
seanmcc-msft and
maririos
kfarmer-msft
approved these changes
Jun 28, 2019
pakrym
reviewed
Jun 28, 2019
KrzysztofCwalina
approved these changes
Jul 1, 2019
- Move shared code into folders - Remove unused constants
- Move HttpRange into Common - Rename ID to Id - Rename cancellation to cancellationToken - Move access conditions into .Models - Move remaining options into .Models - Change Enqueue to return a single item instead of an array
pushd $EnlistmentRoot
$projects = "Common", "Blobs", "Queues", "Files"
foreach ($project in $projects) {
$source = ".\artifacts\bin\Azure.Storage.$($project).Tests\Debug\netcoreapp2.1\SessionRecords\"
$dest = ".\sdk\storage\Azure.Storage.$($project)\tests\SessionRecords\"
robocopy /xc /xn /xo /s $source $dest
}
popd
pakrym
reviewed
Jul 2, 2019
| "RequestBody": [ | ||
| "\u003cStorageServiceProperties\u003e\r\n", | ||
| " \u003cLogging\u003e\r\n", | ||
| " \u003cVersion\u003e1.0\u003c/Version\u003e\r\n", |
There was a problem hiding this comment.
I've noticed that the request body is pretty-printed, is it worth disabling the pretty-printing to save bandwidth?
There was a problem hiding this comment.
These are data for recorded tests, correct? If so, I don't think we are actually using any bandwidth.
There was a problem hiding this comment.
Recorded tests store exact thing that was sent over the wire during the Live test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding this on top of the existing Storage API changes, so please only look at the last commit (see #6718 for Part 1):
BlobClient=>Specialized.BlobBaseClientBlobClient : BlobBaseClientwith anUploadmethod for block blobsBlobBaseClient.Download