Adding ClientCertificateCredential to Azure.Idenity #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
approved these changes
Jun 19, 2019
|
|
||
| request.Method = HttpPipelineMethod.Post; | ||
|
|
||
| request.Headers.SetValue("Content-Type", "application/x-www-form-urlencoded"); |
There was a problem hiding this comment.
nit: Is there a member in Azure.Core for form types? If not, maybe we should consider adding it there to keep building that out.
There was a problem hiding this comment.
Agreed. I've added and issue to track this, #6646. I'll make this change in a separate PR since it's a change to Azure.Core and requires rebuilding everything.
chlowell
reviewed
Jun 19, 2019
| @@ -23,7 +25,8 @@ internal class IdentityClient | |||
| private readonly IdentityClientOptions _options; | |||
| private readonly HttpPipeline _pipeline; | |||
| private readonly Uri ImdsEndptoint = new Uri("http://169.254.169.254/metadata/identity/oauth2/token"); | |||
| private readonly string MsiApiVersion = "2018-02-01"; | |||
| private const string MsiApiVersion = "2018-02-01"; | |||
There was a problem hiding this comment.
Irrelevant to this PR but this is the IMDS version. App Service MSI will 400 if you use it there (expects 2017-09-01).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.