Add recorded tests for Storage #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
requested review from
pakrym,
AlexGhiondea,
weshaggard,
KrzysztofCwalina and
maririos
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maririos
reviewed
Jun 18, 2019
|
Changes to Azure.Core testing framework look good! |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -118,17 +118,17 @@ public async Task CreateAsync_Metadata() | |||
| } | |||
|
|
|||
| //TODO | |||
| [Ignore] | |||
| [TestMethod] | |||
| [Ignore("Not yet implemented")] | |||
There was a problem hiding this comment.
Should we have an issue for this?
There was a problem hiding this comment.
I haven't been filing issues for the Storage Team's TODOs that were already in the code. We should chat tomorrow about whether we want to do this and possibly add a work item in the next milestone for me to add issues for all TODOs.
AlexGhiondea
approved these changes
Jun 19, 2019
maririos
approved these changes
Jun 19, 2019
jsquire
approved these changes
Jun 19, 2019
- Improve the StorageRequestFailedException error message - Have Response.Headers.Date return x-ms-date if Date isn't present - Make tests more reliable with MemoryStream.ToArray() instead .GetBuffer() Here's an example of an error message with additional info specified: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature. RequestId:6b6d5a57-201e-007b-2291-250f92000000 Time:2019-06-18T04:53:02.9793056Z Status: 403 (Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.) ErrorCode: AuthenticationFailed Additional Information: AuthenticationErrorDetail: The MAC signature found in the HTTP request 'T8bvpwE2Fp9cKr9yAfo1kblARYwUoRLovmH1nIlPrpQ=' is not the same as any computed signature. Server used following string to sign: 'GET x-ms-client-request-id:097eb32f-12eb-476b-8fe2-e912b96e6974 x-ms-date:Tue, 18 Jun 2019 04:53:01 GMT x-ms-return-client-request-id:true x-ms-version:2018-11-09 /storageteglazatesting/ comp:properties restype:account'. Headers: Server: Microsoft-HTTPAPI/2.0 x-ms-request-id: 6b6d5a57-201e-007b-2291-250f92000000 x-ms-error-code: AuthenticationFailed Date: Tue, 18 Jun 2019 04:53:02 GMT Content-Length: 779 Content-Type: application/xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are tweaking the Storage tests to be less stateful. They used a lot of random values and
DateTimeOffset.Nowwhich needed to be isolated to individual test methods so replaying works correctly. The staticTestHelperclass, in particular, had to be turned into base classes that can access the current testRecordingmember variable.You can set the
AZURE_TEST_MODEenvironment variable toLivefor running tests against the live service,Recordfor updating recordings,Playbackto run the recordings, or leave it empty to default toPlayback. Additionally, all of the Storage test classes allow you to pass theRecordedTestModeenum into theirctorif you want to override the environment variable (only intended for use while developing)./cc @kfarmer-msft and @seanmcc-msft