Enable full signing for test libraries #5994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were silently failing to run the tests on .NET Framework because the test assembly was delay-signed and the xunit test run just outputs a skipping message in this case which made the CI pass but we didn't actually run any tests on .NET Framework.
Filed a couple tracking issues: Azure#5995 Azure#5997
chidozieononiwu
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were silently failing to run the tests on .NET Framework because
the test assembly was delay-signed and the xunit test run just outputs
a skipping message in this case which made the CI pass but we didn't
actually run any tests on .NET Framework.
cc @Azure/azure-sdk-eng