Second pass of policy configuration changes #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
approved these changes
Apr 11, 2019
| 503, // Service Unavailable | ||
| 504 // Gateway Timeout | ||
| ); | ||
| public FixedRetryPolicy RetryPolicy { get; set; } |
There was a problem hiding this comment.
Should the type of this be the base RetryPolicy?
There was a problem hiding this comment.
The current thinking is the following consumption model:
var options = new ConfigurationClientOptions();
options.RetryPolicy.Delay = ...;
options.RetryPolicy.MaxRetries = ...;
var client = new ConfigurationClient(options);
It has its downsides but that's the iteration we're on.
| @@ -56,15 +56,15 @@ public async Task ComponentNameAndVersionReadFromAssembly() | |||
|
|
|||
| class CustomRetryPolicy : RetryPolicy | |||
| { | |||
| protected override bool ShouldRetryResponse(HttpPipelineMessage message, int attempted, out TimeSpan delay) | |||
| protected override bool IsRetriableResponse(HttpPipelineMessage message, int attempted, out TimeSpan delay) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5632
Azure.Base.PipelineandAzure.Base.Pipeline.Policies