Update docIndex to kick off the docs SDK CI run for main #47434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould be kicked off as part of a manual run
JimSuplizio
requested review from
hallipr,
weshaggard and
benbp
as code owners
benbp
reviewed
Dec 6, 2024
danieljurek
reviewed
Dec 6, 2024
danieljurek
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
I see the issue was transient and another retry succeeded in kicking off the pipeline (I canceled that run because I'm just testing functionality)
This failures has nothing to do with my change but rather with an incident that pretty much affected things fetching from azure |
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
|
The docIndex runs ran without issue. The net - core - ci run that's running isn't testing anything in this PR. I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the docs SDK CI runs run a scheduled run against main and the timing of the runs is isn't great. The solution here is to have the docIndex runs kick off SDK CI the run against main the same way we're kicking off the run against the daily branch. This will remove anything fiddly.
As part of this change, add a parameter, defaulting to false, to determine whether or not the SDK CI run should be kicked off.
This is what the parameter I'd added looks like. It's the second checkbox down, unchecked by default.
This is the docIndex run with it unchecked. Notice it didn't kick off the SDK CI run.
This is the docIndex run with it checked. It would have kicked off the run but there's a weird authentication thing happening in pipelines right now that's affecting Azure.