Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalR - Add more properties to the models, add usage API and complete tests #4728

Merged
merged 3 commits into from
Sep 6, 2018
Merged

SignalR - Add more properties to the models, add usage API and complete tests #4728

merged 3 commits into from
Sep 6, 2018

Conversation

allxiao
Copy link
Member

@allxiao allxiao commented Aug 31, 2018 •
edited
Loading

Description

The change is based on the spec PR: Azure/azure-rest-api-specs#3686 . We plan to release the version 0.10.0-preview for the Ignite.

Changes:

  • Add version to the SignalRInstance model
  • Add connection strings to the SignalRKeys model
  • Add usage operations for quota limit related query
  • Add tests

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Sep 4, 2018

@ArieShout will open a new PR once the stable swagger is checked in, Will reopen this PR if anything changes

@dsgouda dsgouda closed this Sep 4, 2018
@allxiao
Copy link
Member Author

allxiao commented Sep 5, 2018

Hi @dsgouda , we plan to stay in preview before Ignite and work on stable api-version and SDK release after that.
Could you please help to reopen the PR? I have prepared the changes according to your review comments locally and will update after reopening.
Thanks,

@dsgouda
Copy link
Contributor

dsgouda commented Sep 5, 2018

Thanks for confirming. Reopening PR. Will review once changes are pushed

@dsgouda dsgouda reopened this Sep 5, 2018
@allxiao
Copy link
Member Author

allxiao commented Sep 6, 2018

Updated the code according to the review comments and rebased to the latest psSdkJson6 branch.

@allxiao allxiao changed the title SignalR GA - Add more properties to the models, add usage API and complete tests SignalR - Add more properties to the models, add usage API and complete tests Sep 6, 2018
dsgouda
dsgouda approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 51f2a6b into Azure:psSdkJson6 Sep 6, 2018
@allxiao allxiao deleted the signalr branch September 10, 2018 03:06
@LGDoor LGDoor mentioned this pull request Sep 12, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allxiao @dsgouda