Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] [DataMovement] Update Remove to TryRemove for ConcurrentDictionary in TransferManager #47038

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[Storage] [DataMovement] Update Remove to TryRemove for ConcurrentDictionary in TransferManager #47038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/storage/Azure.Storage.DataMovement/src/TransferManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,9 @@ await _checkpointer.AddNewJobAsync(
// cleanup any state for a job that didn't even start
try
{
_dataTransfers.Remove(transferId);
// No need to check if we were able to remove the transfer or not.
// If there's no stale DataTransfer to remove, move on, because this is a cleanup
_dataTransfers.TryRemove(transferId, out DataTransfer transfer);
await _checkpointer.TryRemoveStoredTransferAsync(transferId, cancellationToken).ConfigureAwait(false);
}
catch (Exception cleanupEx)
Expand Down
Loading